Correct unnecessary-comprehensions

Author: mxmeinhold

.pylintrc

@@ -12,7 +12,6 @@ disable =
 	bad-continuation,
 	too-few-public-methods,
 	global-statement,
-	unnecessary-comprehension,
 	import-outside-toplevel,
 	cyclic-import,
 	no-else-continue,
@@ -93,4 +92,4 @@ min-public-methods = 2
 max-public-methods = 20
 
 [EXCEPTIONS]
-overgeneral-exceptions = Exception
+overgeneral-exceptions = Exception

conditional/blueprints/housing.py

@@ -27,7 +27,7 @@ def display_housing(user_dict=None):
     log.info('Display Housing Board')
 
     housing = {}
-    onfloors = [account for account in ldap_get_onfloor_members()]
+    onfloors = ldap_get_onfloor_members()
     onfloor_freshmen = FreshmanAccount.query.filter(
         FreshmanAccount.room_number is not None
     )

conditional/blueprints/intro_evals.py

@@ -37,14 +37,14 @@ def get_fid_cm_count(member_id):
             FreshmanCommitteeAttendance.fid == member_id)
             if CommitteeMeeting.query.filter(CommitteeMeeting.id == a.meeting_id).first().approved])
 
-    members = [account for account in ldap_get_intro_members()]
+    members = ldap_get_intro_members()
 
     ie_members = []
 
     # freshmen who don't have accounts
-    fids = [f for f in FreshmanAccount.query.filter(
+    fids = list(FreshmanAccount.query.filter(
         FreshmanAccount.eval_date > start_of_year(),
-        FreshmanAccount.eval_date > datetime.now())]
+        FreshmanAccount.eval_date > datetime.now()))
 
     for fid in fids:
         h_meetings = [m.meeting_id for m in

conditional/blueprints/spring_evals.py

@@ -23,7 +23,7 @@ def display_spring_evals(internal=False, user_dict=None):
     log = logger.new(request=request, auth_dict=user_dict)
     log.info('Display Membership Evaluations Listing')
 
-    active_members = [account for account in ldap_get_active_members()]
+    active_members = ldap_get_active_members()
 
     sp_members = []
     for account in active_members:

conditional/util/member.py

@@ -49,7 +49,7 @@ def get_voting_members():
 
 @service_cache(maxsize=1024)
 def get_members_info():
-    members = [account for account in ldap_get_current_students()]
+    members = ldap_get_current_students()
     member_list = []
 
     for account in members: