JS Repairs with Hidden

Author: jabbate19

quotefault/__init__.py

@@ -325,7 +325,7 @@ def hide(quote_id):
     """
     metadata = get_metadata()
     quote = Quote.query.get(quote_id)
-    if not metadata['is_admin']:
+    if not (metadata['uid'] == quote.submitter or metadata['uid'] == quote.speaker or metadata['is_admin']):
         abort(403)
     if not quote:
         abort(404)

quotefault/templates/bootstrap/admin.html

@@ -10,17 +10,6 @@
         {% with messages = get_flashed_messages(with_categories=true) %}
             {% if messages %}
                 {% for category, message in messages %}
-                    <script>
-                        switch (category) {
-                            case warning:
-                                category = warning
-                            case error:
-                                category = danger
-                            case
-                            default:
-                                category = success
-                        }
-                    </script>
                     <div class="alert alert-{{ category }}" role="alert">
                         {{ message }}
                     </div>

quotefault/templates/bootstrap/hidden.html

@@ -10,28 +10,18 @@
         // Get the modal
         var modal = document.getElementById(`unhide_${id}`);
         modal.style.display = "block";
-    }
-    function unhideClose(id){
-        // Get the modal
-        var modal = document.getElementById(`unhide_${id}`);
-        modal.style.display = "none";
-    }
+        }
+        function unhideClose(id){
+            // Get the modal
+            var modal = document.getElementById(`unhide_${id}`);
+            modal.style.display = "none";
+        }
     </script>
     <div class="container">
         <!-- flash relevant message when submit button is clicked -->
         {% with messages = get_flashed_messages(with_categories=true) %}
             {% if messages %}
                 {% for category, message in messages %}
-                    <script>
-                        switch (category) {
-                            case warning:
-                                category = warning
-                            case error:
-                                category = danger
-                            default:
-                                category = success
-                        }
-                    </script>
                     <div class="alert alert-{{ category }}" role="alert">
                         {{ message }}
                     </div>

quotefault/templates/bootstrap/main.html

@@ -6,17 +6,6 @@
         {% with messages = get_flashed_messages(with_categories=true) %}
             {% if messages %}
                 {% for category, message in messages %}
-                    <script>
-                        switch (category) {
-                            case warning:
-                                category = warning
-                            case error:
-                                category = danger
-                            case
-                            default:
-                                category = success
-                        }
-                    </script>
                     <div class="alert alert-{{ category }}" role="alert">
                         {{ message }}
                     </div>

quotefault/templates/bootstrap/storage.html

@@ -32,16 +32,6 @@
         {% with messages = get_flashed_messages(with_categories=true) %}
             {% if messages %}
                 {% for category, message in messages %}
-                    <script>
-                        switch (category) {
-                            case warning:
-                                category = warning
-                            case error:
-                                category = danger
-                            default:
-                                category = success
-                        }
-                    </script>
                     <div class="alert alert-{{ category }}" role="alert">
                         {{ message }}
                     </div>