Final fix for adding users...

Author: RSTZZZ

src/python/add_update_member.py

@@ -53,7 +53,7 @@ def process_role_data(parsed: Dict, prefix: str = "") -> Optional[Dict]:
     if affiliation and affiliation != "_No response_":
         role["affiliation"] = affiliation
 
-    research_directions = parsed.get(f"{prefix}research-directions")
+    research_directions = parsed.get(f"{prefix}research_directions")
     if research_directions and research_directions != "_No response_":
         # Handle both string and list inputs for research directions
         if isinstance(research_directions, str):
@@ -74,12 +74,12 @@ def format_parsed_content(parsed: Dict) -> Dict:
     }
 
     # Process current role
-    current_role = process_role_data(parsed, "current_role-")
+    current_role = process_role_data(parsed, "current_role_")
     if current_role:
         formatted["current_role"] = current_role
 
     # Process past role if it exists (for updates)
-    past_role = process_role_data(parsed, "past_role-")
+    past_role = process_role_data(parsed, "past_role_")
     if past_role:
         formatted["past_roles"] = past_role
 

tests/data/add_member/in.md

@@ -14,36 +14,36 @@ _No response_
 
 _No response_
 
-### Semantic_scholar_id
+### Semantic Scholar ID
 
-_No response_
+145113126
 
-### Auto_update_publications
+### Auto Update Publications
 
-False
+True
 
-### Current_role-type
+### Current Role Type
 
 Student
 
-### Current_role-title
+### Current Role Title
 
 PhD
 
-### Current_role-affiliation
+### Current Role Affiliation
 
 Mila, McGill
 
-### Current_role-research-directions
+### Current Role Research Directions
 
 online-toxicity, poli-sci
 
 
-### Current_role-advisor
+### Current Role Advisor
 
 Reihaneh Rabbany
 
-### Current_role-start_date
+### Current Role Start Date
 
 Fall 2019
 

tests/data/add_member/out.json

@@ -1,7 +1,8 @@
 {
     "name": "John Doe",
     "avatar": "/tests/scratch/assets/images/bio/John Doe.jpg",
-    "auto_update_publications": false,
+    "semantic_scholar_id": "145113126",
+    "auto_update_publications": true,
     "current_role": {
         "type": "Student",
         "title": "PhD",

tests/data/update_member/in.md

@@ -18,27 +18,27 @@ Allergic to reviewer 2
 
 145113126
 
-### Auto_update_publications
+### Auto Update Publications
 
 True
 
-### Current_role-type
+### Current Role Type
 
 Unaffiliated
 
-### Current_role-title
+### Current Role Title
 
 Professing at Leland S. Junior University
 
-### Current_role-research-directions
+### Current Role Research Directions
 
 online-toxicity, poli-sci, online-crime
 
-### Current_role-advisor
+### Current Role Advisor
 
 _No response_
 
-### Current_role-start_date
+### Current Role Start Date
 
 _No response_
 
@@ -62,22 +62,22 @@ https://www.linkedin.com/in/fake_user/
 
 _No response_
 
-### Past_role-type
+### Past Role Type
 
 Student
 
-### Past_role-title
+### Past Role Title
 
 PhD
 
-### Past_role-advisor
+### Past Role Advisor
 
 Reihaneh Rabbany
 
-### Past_role-start_date
+### Past Role Start Date
 
 Fall 2019
 
-### Past_role-end_date
+### Past Role End Date
 
 Winter 2023

tests/test_add_update_member.py

@@ -47,8 +47,6 @@ def test_add_member(self):
 
         output = json.loads(json.dumps(out['John Doe']))
 
-        print(output)
-        print(expected)
         self.assertEqual(output, expected)
 
     def test_update_member(self):
@@ -73,8 +71,6 @@ def test_update_member(self):
 
         error_message = f"\n\n!!! Expected content of generated file to match content of file {exp_out_path}, but they did not match !!!"
 
-        print(output)
-        print(expected)
         self.assertEqual(output, expected, error_message)