fix: sheet is smaller than expected #2, or might be displayed on the wrong window (or not displayed) #4

Author: EchoEllet

macos/native_image_picker_macos/Sources/native_image_picker_macos/ImagePickerImpl.swift

@@ -8,6 +8,12 @@ import PhotosUI
 /// to use [PHPickerViewController](https://developer.apple.com/documentation/photokit/phpickerviewcontroller) which is supported on macOS 13.0+
 /// otherwise fallback to file selector if unsupported or the user prefers the file selector implementation.
 class ImagePickerImpl: NSObject, ImagePickerApi {
+  private let view: NSView?
+
+  init(view: NSView?) {
+    self.view = view
+  }
+
   /// Returns `true` if the current macOS version supports this feature.
   ///
   /// `PHPicker` is supported on macOS 13.0+.
@@ -107,11 +113,20 @@ class ImagePickerImpl: NSObject, ImagePickerApi {
   @available(macOS 13, *)
   private func showPHPicker(_ picker: PHPickerViewController, noActiveWindow: @escaping () -> Void)
   {
-    guard let window = NSApplication.shared.keyWindow else {
+    guard let window = view?.window else {
       noActiveWindow()
       return
     }
-    // TODO(EchoEllet): IMPORTANT The window size of the picker is smaller than expected, see the video in https://discord.com/channels/608014603317936148/1295165633931120642/1295470850283147335
+
+    let windowSize = window.frame.size
+
+    let scaleFactor = 0.80  // 80% of the parent window's size
+
+    var pickerWidth = windowSize.width * scaleFactor
+    var pickerHeight = windowSize.height * scaleFactor
+
+    picker.view.frame = NSRect(x: 0, y: 0, width: pickerWidth, height: pickerHeight)
+
     window.contentViewController?.presentAsSheet(picker)
   }
 

macos/native_image_picker_macos/Sources/native_image_picker_macos/NativeImagePickerPlugin.swift

@@ -4,7 +4,7 @@ import FlutterMacOS
 public class NativeImagePickerPlugin: NSObject, FlutterPlugin {
   public static func register(with registrar: FlutterPluginRegistrar) {
     let messenger = registrar.messenger
-    let api = ImagePickerImpl()
+    let api = ImagePickerImpl(view: registrar.view)
     ImagePickerApiSetup.setUp(binaryMessenger: messenger, api: api)
   }
 }

pigeons/messages.dart

@@ -66,6 +66,7 @@ enum ImagePickerError {
   phpickerUnsupported,
 
   /// Could not show the picker due to the missing window.
+  /// This May occur if the `NSView` is `nil`, for instance in a headless environment.
   windowNotFound,
 
   /// When a `PHPickerResult` can't load `NSImage`. This error should not be reached