Skip to content

Commit 4a4f0ce

Browse files
committed
Fix a UI-off-main-thread bug
1 parent e9c0559 commit 4a4f0ce

File tree

1 file changed

+9
-8
lines changed

1 file changed

+9
-8
lines changed

Hammerspoon/MJPreferencesWindowController.m

Lines changed: 9 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -67,16 +67,17 @@ - (void) reflectDefaults {
6767
}
6868

6969
- (void)updateFeedbackDisplay:(NSNotification __unused *)notification {
70-
[self.openAtLoginCheckbox setState:MJAutoLaunchGet() ? NSControlStateValueOn : NSControlStateValueOff];
71-
[self.showDockIconCheckbox setState: MJDockIconVisible() ? NSControlStateValueOn : NSControlStateValueOff];
72-
[self.showMenuIconCheckbox setState: MJMenuIconVisible() ? NSControlStateValueOn : NSControlStateValueOff];
73-
[self.keepConsoleOnTopCheckbox setState: MJConsoleWindowAlwaysOnTop() ? NSControlStateValueOn : NSControlStateValueOff];
74-
[self.uploadCrashDataCheckbox setState: HSUploadCrashData() ? NSControlStateValueOn : NSControlStateValueOff];
70+
dispatch_async(dispatch_get_main_queue(), ^{
71+
[self.openAtLoginCheckbox setState:MJAutoLaunchGet() ? NSControlStateValueOn : NSControlStateValueOff];
72+
[self.showDockIconCheckbox setState: MJDockIconVisible() ? NSControlStateValueOn : NSControlStateValueOff];
73+
[self.showMenuIconCheckbox setState: MJMenuIconVisible() ? NSControlStateValueOn : NSControlStateValueOff];
74+
[self.keepConsoleOnTopCheckbox setState: MJConsoleWindowAlwaysOnTop() ? NSControlStateValueOn : NSControlStateValueOff];
75+
[self.uploadCrashDataCheckbox setState: HSUploadCrashData() ? NSControlStateValueOn : NSControlStateValueOff];
7576
#ifndef SENTRY_API_URL
76-
[self.uploadCrashDataCheckbox setState:NSControlStateValueOff];
77-
[self.uploadCrashDataCheckbox setEnabled:NO];
77+
[self.uploadCrashDataCheckbox setState:NSControlStateValueOff];
78+
[self.uploadCrashDataCheckbox setEnabled:NO];
7879
#endif
79-
80+
});
8081
}
8182

8283
- (void) showWindow:(id)sender {

0 commit comments

Comments
 (0)