Skip to content

Commit 4f04c28

Browse files
Address some more code review
Co-authored-by: willkroboth <46540330+willkroboth@users.noreply.github.com>
1 parent 3eb3d19 commit 4f04c28

File tree

3 files changed

+5
-5
lines changed

3 files changed

+5
-5
lines changed

docs/en/create-commands/registration.md

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -219,6 +219,8 @@ Places where you can register commands are listed below:
219219
|--------------------------------|-----------------------------------------------------------------|
220220
| `onLoad()`/`onEnable()` method | Register regular commands not available in datapacks by default |
221221

222+
If you want your command to be accessible in Minecraft functions, make sure the [datapack reload](../user-setup/config#skip-initial-datapack-reload) process is set to `false`.
223+
222224
</div>
223225

224-
The CommandAPI does support registering commands outside of these methods while the server is running. Commands registered after the server is done loading _should_ work the same as commands registered in `onLoad()`/`onEnable()`.
226+
The CommandAPI does support registering commands anytime after the server is done loading. Commands registered while the server is running _should_ work the same as commands registered in `onLoad()`/`onEnable()`.

docs/en/dev-setup/shading.md

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -31,9 +31,7 @@ If you want to handle reloading, the CommandAPI has minimal support for it with
3131

3232
### Loading
3333

34-
The `onLoad(CommandAPIConfig)` method initializes the CommandAPI's loading sequence. This must be called _before_ you start to access the CommandAPI and must be placed in your plugin's `onLoad()` method. The argument `CommandAPIConfig` is used to configure how the CommandAPI works. The `CommandAPIConfig` class has the following parameters which let you set how the CommandAPI works similar to the `config.yml`, which is described [here](../user-setup/config).
35-
36-
The `CommandAPIConfig` class follows a typical builder pattern (without you having to run `.build()` at the end), which lets you easily construct configuration instances.
34+
The `onLoad(CommandAPIConfig)` method initializes the CommandAPI. This must be called _before_ you access any other CommandAPI features. The `CommandAPIConfig` argument is used to configure how the CommandAPI works, similar to the `config.yml`. The `CommandAPIConfig` class follows a builder pattern, with methods for each option in the `config.yml`, which are listed and described [here](../user-setup/config).
3735

3836
<div class="paper">
3937

update.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ echo "New version:"
55
read -r newVer
66

77
# Update CommandAPI dependency versions
8-
sed -i "s/commandApiVersion=$oldVer/commandApiVersion$newVer/" reference-code/gradle.properties
8+
sed -i "s/commandApiVersion=$oldVer/commandApiVersion=$newVer/" reference-code/gradle.properties
99

1010
# Update CommandAPI version in documentation files (Maven)
1111
sed -i "s/<version>$oldVer<\/version>/<version>$newVer<\/version>/" docs/en/dev-setup/annotations.md

0 commit comments

Comments
 (0)