feat: Add media type filtering to Media Asset Panel #6701
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viva-jinyi
requested review from
a team,
KarryCharon,
Yorha4D and
shinshin86
as code owners
dosubot
bot
added
the
size:L
🎨 Storybook Build Status✅ Build completed successfully! ⏰ Completed at: 11/15/2025, 05:11:30 AM UTC 🔗 Links🎉 Your Storybook is ready for review! |
🎭 Playwright Test Results⏰ Completed at: 11/15/2025, 05:21:54 AM UTC 📈 Summary
📊 Test Reports by Browser
🎉 Click on the links above to view detailed test results for each browser configuration. |
Bundle Size ReportSummary
Category Glance Per-category breakdownApp Entry Points — 2.98 MB (baseline 2.98 MB) • 🔴 +123 BMain entry bundles and manifests
Status: 3 added / 3 removed Graph Workspace — 803 kB (baseline 803 kB) • ⚪ 0 BGraph editor runtime, canvas, workflow orchestration
Status: 1 added / 1 removed Views & Navigation — 8.03 kB (baseline 8.03 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces
Status: 1 added / 1 removed Panels & Settings — 307 kB (baseline 307 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens
Status: 6 added / 6 removed UI Components — 210 kB (baseline 210 kB) • ⚪ 0 BReusable component library chunks
Status: 5 added / 5 removed Data & Services — 12.6 kB (baseline 12.6 kB) • ⚪ 0 BStores, services, APIs, and repositories
Status: 2 added / 2 removed Utilities & Hooks — 5.87 kB (baseline 5.87 kB) • ⚪ 0 BHelpers, composables, and utility bundles
Status: 1 added / 1 removed Vendor & Third-Party — 5.32 MB (baseline 5.32 MB) • ⚪ 0 BExternal libraries and shared vendor chunks
Other — 3.92 MB (baseline 3.92 MB) • ⚪ 0 BBundles that do not match a named category
Status: 15 added / 15 removed |
🔧 Auto-fixes AppliedThis PR has been automatically updated to fix linting and formatting issues.
Changes made:
|
DrJKL
reviewed
Nov 14, 2025
DrJKL
reviewed
Nov 14, 2025
DrJKL
reviewed
Nov 14, 2025
DrJKL
reviewed
Nov 14, 2025
DrJKL
requested changes
Nov 14, 2025
Contributor
DrJKL
left a comment
DrJKL
left a comment
There was a problem hiding this comment.
Only changes I'd really like to see are using the design tokens instead of dark-theme:
viva-jinyi
force-pushed
the
feature/media-asset-filtering
branch
from
00dd58b to
2754928
Compare
미디어 애셋 패널에 미디어 타입 필터링 기능을 추가했습니다. - Image, Video, Audio, 3D 타입별로 멀티 선택 필터링 가능 - MediaAssetFilterButton 및 MediaAssetFilterMenu 컴포넌트 추가 - useMediaAssetFiltering composable에 타입 필터링 로직 구현 - 필터는 검색 및 정렬과 함께 동작 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
미디어 타입 필터링이 작동하지 않던 버그 수정. filteredAssets에서 typeFiltered 대신 searchFiltered를 사용하고 있었음. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
추후 재사용 가능한 Checkbox 컴포넌트로 리팩토링 예정: - 네이티브 checkbox를 숨기고 커스텀 스타일 적용 - 시맨틱 토큰 사용 - MediaAssetFilterMenu, MultiSelect, SingleSelect에서 사용 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
viva-jinyi
force-pushed
the
feature/media-asset-filtering
branch
from
2754928 to
f25e321
Compare
🔧 Auto-fixes AppliedThis PR has been automatically updated to fix linting and formatting issues.
Changes made:
|
Member
Author
|
@DrJKL Can you review it again? |
DrJKL
approved these changes
Nov 15, 2025
|
|
||
| <Popover | ||
| ref="popover" | ||
| :append-to="'body'" |
Contributor
There was a problem hiding this comment.
This piece should be fixed soon, but if this works 👍🏻
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add media type filtering functionality to the Media Asset Panel, allowing users to filter assets by Image, Video, Audio, and 3D types.
Changes
typeFilteredinstead ofsearchFilteredinfilteredAssetsFeatures
TODO
Test Plan
🤖 Generated with Claude Code