other PR code review fixes

Author: luke-mino-altherr

src/locales/en/main.json

@@ -2009,7 +2009,7 @@
     "modelTypeSelectorPlaceholder": "Select model type",
     "selectModelType": "Select model type",
     "notSureLeaveAsIs": "Not sure? Just leave this as is",
-    "modelUploaded": "Model uploaded!",
+    "modelUploaded": "Model uploaded! 🎉",
     "findInLibrary": "Find it in the {type} section of the models library.",
     "finish": "Finish",
     "allModels": "All Models",

src/platform/assets/components/UploadModelConfirmation.vue

@@ -17,8 +17,13 @@
       </label>
       <SingleSelect
         v-model="selectedModelType"
-        :label="$t('assetBrowser.modelTypeSelectorPlaceholder')"
+        :label="
+          isLoading
+            ? $t('g.loading')
+            : $t('assetBrowser.modelTypeSelectorPlaceholder')
+        "
         :options="modelTypes"
+        :disabled="isLoading"
       />
       <div class="flex items-center gap-2 text-sm text-muted">
         <i class="icon-[lucide--info]" />
@@ -44,7 +49,7 @@ const emit = defineEmits<{
   'update:modelValue': [value: string | undefined]
 }>()
 
-const { modelTypes } = useModelTypes()
+const { modelTypes, isLoading } = useModelTypes()
 
 const selectedModelType = computed({
   get: () => props.modelValue ?? null,

src/platform/assets/components/UploadModelProgress.vue

@@ -19,7 +19,7 @@
     <div v-else-if="status === 'success'" class="flex flex-col gap-8">
       <div class="flex flex-col gap-4">
         <p class="text-sm text-muted m-0 font-bold">
-          {{ $t('assetBrowser.modelUploaded') }} 🎉
+          {{ $t('assetBrowser.modelUploaded') }}
         </p>
         <p class="text-sm text-muted m-0">
           {{ $t('assetBrowser.findInLibrary', { type: modelType }) }}
@@ -45,7 +45,7 @@
       v-else-if="status === 'error'"
       class="flex flex-1 flex-col items-center justify-center gap-6"
     >
-      <i class="icon-[lucide--x-circle] text-6xl text-red-500" />
+      <i class="icon-[lucide--x-circle] text-6xl text-error" />
       <div class="text-center">
         <p class="m-0 text-sm font-bold">
           {{ $t('assetBrowser.uploadFailed') }}

src/platform/assets/schemas/assetSchema.ts

@@ -55,7 +55,6 @@ export const assetFilenameSchema = z
 // Export schemas following repository patterns
 export const assetItemSchema = zAsset
 export const assetResponseSchema = zAssetResponse
-export const assetMetadataSchema = zAssetMetadata
 
 // Export types derived from Zod schemas
 export type AssetItem = z.infer<typeof zAsset>