From 2d06b9bbd14bb2085717d4441961a03e7b45f6d5 Mon Sep 17 00:00:00 2001 From: Bhargav Mangipudi Date: Wed, 5 Apr 2017 17:41:22 -0500 Subject: [PATCH] Fix evalution issue with PredicateArgumentEvaluator. - `evaluateSense` method requires attributes as part of the evaluation. - `evaluate` methods remotes attributes in the gold and predicted views. - Calling `evaluate` before `evaluateSense` causes the evaluation to fail as the attributes are missing now. --- .../core/experiments/evaluators/PredicateArgumentEvaluator.java | 1 - 1 file changed, 1 deletion(-) diff --git a/core-utilities/src/main/java/edu/illinois/cs/cogcomp/core/experiments/evaluators/PredicateArgumentEvaluator.java b/core-utilities/src/main/java/edu/illinois/cs/cogcomp/core/experiments/evaluators/PredicateArgumentEvaluator.java index 23ba28df9..07b12b61b 100644 --- a/core-utilities/src/main/java/edu/illinois/cs/cogcomp/core/experiments/evaluators/PredicateArgumentEvaluator.java +++ b/core-utilities/src/main/java/edu/illinois/cs/cogcomp/core/experiments/evaluators/PredicateArgumentEvaluator.java @@ -56,7 +56,6 @@ public void evaluateSense(ClassificationTester senseTester, View goldView, View * @param tester The multi-class {@link ClassificationTester} for the argument labels */ public void evaluate(ClassificationTester tester, View goldView, View predictionView) { - super.cleanAttributes(goldView, predictionView); gold = (PredicateArgumentView) goldView; prediction = (PredicateArgumentView) predictionView; goldToPredictionPredicateMapping = getGoldToPredictionPredicateMapping();