Use request/response objects

Author: rsaladocid

src/Contexts/Mooc/Courses/application/CourseCreator.ts

@@ -1,15 +1,16 @@
-import CourseRepository from '../domain/CourseRepository';
-import Course from '../domain/Course';
+import { CourseRepository } from '../domain/CourseRepository';
+import { Course } from '../domain/Course';
+import { CreateCourseRequest } from './CreateCourseRequest';
 
-export default class CourseCreator {
+export class CourseCreator {
   private repository: CourseRepository;
 
   constructor(repository: CourseRepository) {
     this.repository = repository;
   }
 
-  async run(id: string, name: string, duration: string): Promise<void> {
-    const course = new Course(id, name, duration);
+  async run(request: CreateCourseRequest): Promise<void> {
+    const course = new Course(request.id, request.name, request.duration);
 
     return this.repository.save(course);
   }

src/Contexts/Mooc/Courses/application/CreateCourseRequest.ts

@@ -0,0 +1,5 @@
+export type CreateCourseRequest = {
+  id: string;
+  name: string;
+  duration: string;
+};

src/apps/mooc_backend/controllers/CoursePutController.ts

@@ -1,8 +1,8 @@
 import { Request, Response } from 'express';
-import CourseCreator from '../../../Contexts/Mooc/Courses/application/CourseCreator';
+import { CourseCreator } from '../../../Contexts/Mooc/Courses/application/CourseCreator';
 import httpStatus from 'http-status';
-import Controller from './Controller';
-import CourseAlreadyExists from '../../../Contexts/Mooc/Courses/domain/CourseAlreadyExists';
+import { Controller } from './Controller';
+import { CourseAlreadyExists } from '../../../Contexts/Mooc/Courses/domain/CourseAlreadyExists';
 
 export class CoursePutController implements Controller {
   constructor(private courseCreator: CourseCreator) {}
@@ -13,15 +13,13 @@ export class CoursePutController implements Controller {
     const duration: string = req.body.duration;
 
     try {
-      await this.courseCreator.run(id, name, duration);
-    } catch (e) {
-
-      if (e instanceof CourseAlreadyExists) {
-        res.status(httpStatus.BAD_REQUEST).send(e.message);
+      await this.courseCreator.run({ id, name, duration });
+    } catch (error) {
+      if (error instanceof CourseAlreadyExists) {
+        res.status(httpStatus.BAD_REQUEST).send(error.message);
       } else {
-        res.status(httpStatus.INTERNAL_SERVER_ERROR).json(e);
+        res.status(httpStatus.INTERNAL_SERVER_ERROR).json(error);
       }
-
     }
 
     res.status(httpStatus.CREATED).send();

tests/Contexts/Mooc/Courses/application/CourseCreator.test.ts

@@ -1,6 +1,6 @@
-import Course from '../../../../../src/Contexts/Mooc/Courses/domain/Course';
-import CourseCreator from '../../../../../src/Contexts/Mooc/Courses/application/CourseCreator';
-import CourseRepository from '../../../../../src/Contexts/Mooc/Courses/domain/CourseRepository';
+import { Course } from '../../../../../src/Contexts/Mooc/Courses/domain/Course';
+import { CourseCreator } from '../../../../../src/Contexts/Mooc/Courses/application/CourseCreator';
+import { CourseRepository } from '../../../../../src/Contexts/Mooc/Courses/domain/CourseRepository';
 
 describe('Course Creator', () => {
   it('should create a valid course', async () => {
@@ -18,7 +18,7 @@ describe('Course Creator', () => {
 
     const course = new Course(id, name, duration);
 
-    await createCourse.run(id, name, duration);
+    await createCourse.run({ id, name, duration });
 
     expect(save).toHaveBeenCalledWith(course);
   });