Remove BackofficeCourseAlreadyExists error from BackofficeCourse creator

Author: vilasmaciel

src/Contexts/Backoffice/Courses/application/Create/BackofficeCourseCreator.ts

@@ -1,8 +1,4 @@
-import { Criteria } from '../../../../Shared/domain/criteria/Criteria';
-import { Filters } from '../../../../Shared/domain/criteria/Filters';
-import { Order } from '../../../../Shared/domain/criteria/Order';
 import { BackofficeCourse } from '../../domain/BackofficeCourse';
-import { BackofficeCourseAlreadyExists } from '../../domain/BackofficeCourseAlreadyExists';
 import { BackofficeCourseDuration } from '../../domain/BackofficeCourseDuration';
 import { BackofficeCourseId } from '../../domain/BackofficeCourseId';
 import { BackofficeCourseName } from '../../domain/BackofficeCourseName';
@@ -18,26 +14,6 @@ export class BackofficeCourseCreator {
       new BackofficeCourseDuration(duration)
     );
 
-    const criteria = this.buildCriteria(id);
-    const alreadyExists = await this.courseAlreadyExists(criteria);
-    if (alreadyExists) {
-      throw new BackofficeCourseAlreadyExists(new BackofficeCourseId(id));
-    }
-
     return this.backofficeCourseRepository.save(course);
   }
-
-  private async courseAlreadyExists(criteria: Criteria) {
-    const current = await this.backofficeCourseRepository.matching(criteria);
-    return current.length > 0;
-  }
-
-  buildCriteria(id: string): Criteria {
-    const filter = new Map<string, string>();
-    filter.set('field', 'id');
-    filter.set('operator', '=');
-    filter.set('value', id);
-    const filters = Filters.fromValues([filter]);
-    return new Criteria(filters, Order.none());
-  }
 }

src/Contexts/Backoffice/Courses/domain/BackofficeCourseAlreadyExists.ts

@@ -1,5 +1,4 @@
 import { BackofficeCourseCreator } from '../../../../../../src/Contexts/Backoffice/Courses/application/Create/BackofficeCourseCreator';
-import { BackofficeCourseAlreadyExists } from '../../../../../../src/Contexts/Backoffice/Courses/domain/BackofficeCourseAlreadyExists';
 import { BackofficeCourseMother } from '../../domain/BackofficeCourseMother';
 import { BackofficeCourseRepositoryMock } from '../../__mocks__/BackofficeCourseRepositoryMock';
 
@@ -14,15 +13,4 @@ describe('BackofficeCourseCreator', () => {
 
     repository.assertSaveHasBeenCalledWith(course);
   });
-
-  it('throws an error if the course already exists', async () => {
-    const course = BackofficeCourseMother.random();
-    const repository = new BackofficeCourseRepositoryMock();
-    repository.returnMatching([course]);
-    const applicationService = new BackofficeCourseCreator(repository);
-
-    expect(
-      applicationService.run(course.id.toString(), course.duration.toString(), course.name.toString())
-    ).rejects.toBeInstanceOf(BackofficeCourseAlreadyExists);
-  });
 });

tests/Contexts/Backoffice/Courses/application/Create/BackofficeCourseCreator.test.ts

@@ -40,20 +40,6 @@ describe('List courses', () => {
     cy.get('#courses-list tr').eq(0).should('contain', 'Random Course');
     cy.get('#courses-list tr').eq(0).should('contain', '2 hours');
   });
-
-  it('handle invalid filters', () => {
-    createCourses();
-
-    cy.get('button[data-cy="add-field-button"').click();
-    cy.get('[data-cy=field-filter]').select('name');
-    cy.get('[data-cy=field-filter-type]').select('CONTAINS');
-    cy.get('#filter-button').click();
-
-    cy.contains('Cursos existentes');
-    cy.get('#courses-list').find('tr').should('have.length', 1);
-    cy.get('#courses-list tr').eq(0).should('contain', 'Random Course');
-    cy.get('#courses-list tr').eq(0).should('contain', '2 hours');
-  });
 });
 function createCourses() {
   cy.get('input[name="name"]').type('DDD en Typescript');