Handle not found exceptions in Elastic repositories

Author: vilasmaciel

src/Contexts/Shared/infrastructure/persistence/elasticsearch/ElasticRepository.ts

@@ -1,4 +1,6 @@
 import { Client as ElasticClient } from '@elastic/elasticsearch';
+import { ResponseError } from '@elastic/elasticsearch/lib/errors';
+import httpStatus from 'http-status';
 import { AggregateRoot } from '../../../domain/AggregateRoot';
 
 type Hit = { _source: any };
@@ -15,16 +17,27 @@ export abstract class ElasticRepository<T extends AggregateRoot> {
   protected async searchAllInElastic(unserializer: (data: any) => T): Promise<T[]> {
     const client = await this.client();
 
-    const response = await client.search({
-      index: this.moduleName(),
-      body: {
-        query: {
-          match_all: {}
+    try {
+      const response = await client.search({
+        index: this.moduleName(),
+        body: {
+          query: {
+            match_all: {}
+          }
         }
+      });
+      return response.body.hits.hits.map((hit: Hit) => unserializer({ ...hit._source }));
+    } catch (e) {
+      if (this.isNotFoundError(e)) {
+        return [];
       }
-    });
 
-    return response.body.hits.hits.map((hit: Hit) => unserializer({ ...hit._source }));
+      throw e;
+    }
+  }
+
+  private isNotFoundError(e: any) {
+    return e instanceof ResponseError && (e as ResponseError).meta.statusCode === httpStatus.NOT_FOUND;
   }
 
   protected async persist(aggregateRoot: T): Promise<void> {

tests/Contexts/Backoffice/Courses/infrastructure/BackofficeCourseRepository.test.ts

@@ -7,6 +7,10 @@ import { BackofficeCourseMother } from '../domain/BackofficeCourseMother';
 const repository: ElasticBackofficeCourseRepository = container.get('Backoffice.courses.BackofficeCourseRepository');
 const environmentArranger: Promise<EnvironmentArranger> = container.get('Backoffice.Backend.EnvironmentArranger');
 
+beforeEach(async () => {
+  await (await environmentArranger).arrange();
+});
+
 afterEach(async () => {
   await (await environmentArranger).arrange();
 });
@@ -20,7 +24,7 @@ describe('BackofficeCourseRepository', () => {
 
       const expectedCourses = await repository.searchAll();
 
-      expect(courses.length).toEqual(expectedCourses.length);
+      expect(courses).toHaveLength(expectedCourses.length);
       expect(courses.sort(sort)).toEqual(expectedCourses.sort(sort));
     });
   });

tests/Contexts/Mooc/Courses/infrastructure/persistence/CourseRepository.test.ts

@@ -11,6 +11,7 @@ beforeEach(async () => {
 });
 
 afterAll(async () => {
+  await (await environmentArranger).arrange();
   await (await environmentArranger).close();
 });
 

tests/Contexts/Mooc/CoursesCounter/infrastructure/MongoCoursesCounterRepository.test.ts renamed to tests/Contexts/Mooc/CoursesCounter/infrastructure/CoursesCounterRepository.test.ts

@@ -11,10 +11,11 @@ beforeEach(async () => {
 });
 
 afterAll(async () => {
+  await (await environmentArranger).arrange();
   await (await environmentArranger).close();
 });
 
-describe('MongoCoursesCounterRepository', () => {
+describe('CoursesCounterRepository', () => {
   describe('#save', () => {
     it('should save a courses counter', async () => {
       const course = CoursesCounterMother.random();