Skip to content

Commit f31d736

Browse files
committed
[java][booking][04_tell_dont_ask] Move logic inside DateRange
1 parent 228179b commit f31d736

File tree

2 files changed

+6
-10
lines changed

2 files changed

+6
-10
lines changed

examples/java/java-booking-04_tell_dont_ask/src/main/java/tv/codely/booking/Booking.java

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -27,18 +27,14 @@ public Booking(
2727
}
2828

2929
public BookingStatus statusFor(LocalDateTime date) {
30-
if (date.isBefore(dateRange.startDate())) {
30+
if (dateRange.isAfter(date)) {
3131
return BookingStatus.NOT_STARTED;
3232
}
3333

34-
if (isBetween(date, dateRange)) {
34+
if (dateRange.isBetween(date)) {
3535
return BookingStatus.ACTIVE;
3636
}
3737

3838
return BookingStatus.FINISHED;
3939
}
40-
41-
private boolean isBetween(LocalDateTime date, DateRange dateRange) {
42-
return date.isAfter(dateRange.startDate()) && date.isBefore(dateRange.endDate());
43-
}
4440
}

examples/java/java-booking-04_tell_dont_ask/src/main/java/tv/codely/booking/DateRange.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -11,11 +11,11 @@ public DateRange(LocalDateTime startDate, LocalDateTime endDate) {
1111
this.endDate = endDate;
1212
}
1313

14-
public LocalDateTime startDate() {
15-
return startDate;
14+
public boolean isBetween(LocalDateTime date) {
15+
return date.isAfter(startDate) && date.isBefore(endDate);
1616
}
1717

18-
public LocalDateTime endDate() {
19-
return endDate;
18+
public boolean isAfter(LocalDateTime date) {
19+
return date.isBefore(startDate);
2020
}
2121
}

0 commit comments

Comments
 (0)