Implement User class with primitive types usages as a code smell showcase

Author: JavierCane

examples/php/php-user_modelling-01_base/src/User.php

@@ -6,6 +6,9 @@
 
 final class User
 {
+    private const SPANISH_LANGUAGE = "es";
+    private const UNDERAGE_UNTIL_AGE = 18;
+
     private string $locale;
     private int    $age;
 
@@ -15,13 +18,15 @@ public function __construct(string $locale, int $age)
         $this->age    = $age;
     }
 
-    public function locale(): string
+    public function understandSpanish(): bool
     {
-        return $this->locale;
+        $language = substr($this->locale, 0, 2);
+
+        return $language === self::SPANISH_LANGUAGE;
     }
 
-    public function age(): int
+    public function isUnderage(): bool
     {
-        return $this->age;
+        return $this->age < self::UNDERAGE_UNTIL_AGE;
     }
 }

examples/php/php-user_modelling-01_base/tests/UserTest.php

@@ -10,10 +10,34 @@
 final class UserTest extends TestCase
 {
     /** @test */
-    public function shouldSayHelloWhenGreeting()
+    public function should_detect_spanish_from_spain_as_spanish_language(): void
     {
         $user = new User("es_ES", 20);
 
-        self::assertEquals("es_ES", $user->locale());
+        self::assertTrue($user->understandSpanish());
+    }
+
+    /** @test */
+    public function should_not_detect_english_from_great_britain_as_spanish_language(): void
+    {
+        $user = new User("en_GB", 20);
+
+        self::assertFalse($user->understandSpanish());
+    }
+
+    /** @test */
+    public function should_detect_underage_users_until_18_years_old(): void
+    {
+        $user = new User("en_GB", 17);
+
+        self::assertTrue($user->isUnderage());
+    }
+
+    /** @test */
+    public function should_not_detect_underage_users_starting_from_18_years_old(): void
+    {
+        $user = new User("en_GB", 18);
+
+        self::assertFalse($user->isUnderage());
     }
 }