[PHP] [StepStrategy] Move method to StepType hierarchy

Author: JavierCane

examples/php/php-step_strategy-02_replace_type_code_with_strategy/src/ExerciseStepType.php

@@ -6,6 +6,8 @@
 
 final class ExerciseStepType extends StepType
 {
+    public const EXERCISE_STEP_DURATION_ESTIMATION_IN_MINUTES = 30;
+
     public function code(): int
     {
         return StepType::EXERCISE_STEP_TYPE;

examples/php/php-step_strategy-02_replace_type_code_with_strategy/src/QuizStepType.php

@@ -6,6 +6,7 @@
 
 final class QuizStepType extends StepType
 {
+    public const QUIZ_STEP_QUESTION_DURATION_ESTIMATION_IN_MINUTES = 3;
     private array $quizQuestions;
 
     public function __construct(array $quizQuestions)

examples/php/php-step_strategy-02_replace_type_code_with_strategy/src/Step.php

@@ -6,13 +6,10 @@
 
 final class Step
 {
-    private const EXERCISE_STEP_DURATION_ESTIMATION_IN_MINUTES = 30;
-    private const QUIZ_STEP_QUESTION_DURATION_ESTIMATION_IN_MINUTES = 3;
-
     private string   $title;
-    private StepType $type;
-    private ?int     $videoDurationInMinutes;
-    private ?array   $quizQuestions;
+    public StepType $type;
+    public ?int     $videoDurationInMinutes;
+    public ?array   $quizQuestions;
 
     public function __construct(string $title, int $typeCode, ?int $videoDurationInMinutes, ?array $quizQuestions)
     {
@@ -24,25 +21,6 @@ public function __construct(string $title, int $typeCode, ?int $videoDurationInM
 
     public function estimatedCompletionMinutes(): int
     {
-        return $this->stepEstimatedCompletionMinutes();
-    }
-
-    public function stepEstimatedCompletionMinutes()
-    {
-        $estimation = 0;
-
-        switch ($this->type->code()) {
-            case StepType::VIDEO_STEP_TYPE:
-                $estimation = $this->videoDurationInMinutes;
-                break;
-            case StepType::QUIZ_STEP_TYPE:
-                $estimation = self::QUIZ_STEP_QUESTION_DURATION_ESTIMATION_IN_MINUTES * count($this->quizQuestions);
-                break;
-            case StepType::EXERCISE_STEP_TYPE:
-                $estimation = self::EXERCISE_STEP_DURATION_ESTIMATION_IN_MINUTES;
-                break;
-        }
-
-        return $estimation;
+        return $this->type->stepEstimatedCompletionMinutes($this);
     }
 }

examples/php/php-step_strategy-02_replace_type_code_with_strategy/src/StepType.php

@@ -26,5 +26,24 @@ public static function fromPrimitive(int $code, ?int $videoDurationInMinutes, ?a
         }
     }
 
+    public function stepEstimatedCompletionMinutes(Step $instance)
+    {
+        $estimation = 0;
+
+        switch ($instance->type->code()) {
+            case self::VIDEO_STEP_TYPE:
+                $estimation = $instance->videoDurationInMinutes;
+                break;
+            case self::QUIZ_STEP_TYPE:
+                $estimation = QuizStepType::QUIZ_STEP_QUESTION_DURATION_ESTIMATION_IN_MINUTES * count($instance->quizQuestions);
+                break;
+            case self::EXERCISE_STEP_TYPE:
+                $estimation = ExerciseStepType::EXERCISE_STEP_DURATION_ESTIMATION_IN_MINUTES;
+                break;
+        }
+
+        return $estimation;
+    }
+
     abstract public function code(): int;
 }