feat: naming improvement

Author: adrianliz

exercises/tiered_pricing/solutions/adrianliz/java/src/main/java/tv/codely/checkout/PriceRange.java

@@ -0,0 +1,27 @@
+package tv.codely.checkout;
+
+public final class SubscriptionTier {
+
+    private final SubscriptionTierRange range;
+    private final SubscriptionTierPrice price;
+
+    public SubscriptionTier(
+        final SubscriptionTierRange range,
+        final SubscriptionTierPrice price) {
+
+        this.range = range;
+        this.price = price;
+    }
+
+    public boolean isInRange(int numberOfSubscriptions) {
+        return this.range.isSuitableFor(numberOfSubscriptions);
+    }
+
+    public double unitPrice() {
+        return price.unitPrice();
+    }
+
+    public double getTotalPrice(int numberOfSubscriptions) {
+        return unitPrice() * numberOfSubscriptions;
+    }
+}

exercises/tiered_pricing/solutions/adrianliz/java/src/main/java/tv/codely/checkout/SubscriptionPrice.java

@@ -0,0 +1,14 @@
+package tv.codely.checkout;
+
+public final class SubscriptionTierPrice {
+
+    private final double value;
+
+    public SubscriptionTierPrice(double value) {
+        this.value = value;
+    }
+
+    public double unitPrice() {
+        return value;
+    }
+}

exercises/tiered_pricing/solutions/adrianliz/java/src/main/java/tv/codely/checkout/SubscriptionTier.java

@@ -1,11 +1,11 @@
 package tv.codely.checkout;
 
-public final class SubscriptionRange {
+public final class SubscriptionTierRange {
 
     private final int numberOfSubscriptionsFrom;
     private final int numberOfSubscriptionsTo;
 
-    public SubscriptionRange(int numberOfSubscriptionsFrom, int numberOfSubscriptionsTo) {
+    public SubscriptionTierRange(int numberOfSubscriptionsFrom, int numberOfSubscriptionsTo) {
         this.numberOfSubscriptionsFrom = numberOfSubscriptionsFrom;
         this.numberOfSubscriptionsTo = numberOfSubscriptionsTo;
     }
@@ -14,12 +14,4 @@ public boolean isSuitableFor(int numberOfSubscriptions) {
         return numberOfSubscriptions >= numberOfSubscriptionsFrom
             && numberOfSubscriptions <= numberOfSubscriptionsTo;
     }
-
-    public int numberOfSubscriptionsFrom() {
-        return numberOfSubscriptionsFrom;
-    }
-
-    public int numberOfSubscriptionsTo() {
-        return numberOfSubscriptionsTo;
-    }
 }

exercises/tiered_pricing/solutions/adrianliz/java/src/main/java/tv/codely/checkout/SubscriptionTierPrice.java

@@ -4,25 +4,36 @@
 
 public class TieredPricing {
 
-    private final List<PriceRange> priceRanges;
+    private final List<SubscriptionTier> subscriptionTiers;
 
-    public TieredPricing(final List<PriceRange> priceRanges) {
-        this.priceRanges = priceRanges;
+    public TieredPricing(final List<SubscriptionTier> subscriptionTiers) {
+        this.subscriptionTiers = subscriptionTiers;
     }
 
     public TieredPricing() {
         this(List.of(
-            new PriceRange(1, 2, 299),
-            new PriceRange(3, 10, 239),
-            new PriceRange(11, 25, 219),
-            new PriceRange(26, 50, 199),
-            new PriceRange(51, 100, 149)));
+            new SubscriptionTier(
+                new SubscriptionTierRange(1, 2),
+                new SubscriptionTierPrice(299)),
+            new SubscriptionTier(
+                new SubscriptionTierRange(3, 10),
+                new SubscriptionTierPrice(239)),
+            new SubscriptionTier(
+                new SubscriptionTierRange(11, 25),
+                new SubscriptionTierPrice(219)),
+            new SubscriptionTier(
+                new SubscriptionTierRange(26, 50),
+                new SubscriptionTierPrice(199)),
+            new SubscriptionTier(
+                new SubscriptionTierRange(51, 100),
+                new SubscriptionTierPrice(149))));
     }
 
     public double getTotalPrice(int subscriptions) {
-        return priceRanges.stream().filter(priceRange -> priceRange.isInRange(subscriptions))
+        return subscriptionTiers.stream()
+            .filter(subscriptionTier -> subscriptionTier.isInRange(subscriptions))
             .findFirst()
-            .map(priceRange -> priceRange.getTotalPrice(subscriptions))
+            .map(subscriptionTier -> subscriptionTier.getTotalPrice(subscriptions))
             .orElse(0D);
     }
 }

exercises/tiered_pricing/solutions/adrianliz/java/src/main/java/tv/codely/checkout/SubscriptionRange.java renamed to exercises/tiered_pricing/solutions/adrianliz/java/src/main/java/tv/codely/checkout/SubscriptionTierRange.java

@@ -17,11 +17,21 @@ void unit_test_example() {
     void return_total_price_based_on_number_of_subscriptions() {
         final var priceRanges =
             List.of(
-                new PriceRange(new SubscriptionRange(1, 2), new SubscriptionPrice(299)),
-                new PriceRange(new SubscriptionRange(3, 10), new SubscriptionPrice(239)),
-                new PriceRange(new SubscriptionRange(11, 25), new SubscriptionPrice(219)),
-                new PriceRange(new SubscriptionRange(26, 50), new SubscriptionPrice(199)),
-                new PriceRange(new SubscriptionRange(51, 100), new SubscriptionPrice(149)));
+                new SubscriptionTier(
+                    new SubscriptionTierRange(1, 2),
+                    new SubscriptionTierPrice(299)),
+                new SubscriptionTier(
+                    new SubscriptionTierRange(3, 10),
+                    new SubscriptionTierPrice(239)),
+                new SubscriptionTier(
+                    new SubscriptionTierRange(11, 25),
+                    new SubscriptionTierPrice(219)),
+                new SubscriptionTier(
+                    new SubscriptionTierRange(26, 50),
+                    new SubscriptionTierPrice(199)),
+                new SubscriptionTier(
+                    new SubscriptionTierRange(51, 100),
+                    new SubscriptionTierPrice(149)));
         final var tieredPricing = new TieredPricing(priceRanges);
         final var expectedPrice = priceRanges.get(1).unitPrice() * 3;