[php][user_email-03_move_method] Move email validation to User

Author: rgomezcasas

examples/php/php-user_email-03_move_method/src/Controller/NewsletterController.php

@@ -5,12 +5,13 @@
 namespace CodelyTv\Controller;
 
 use CodelyTv\Model\Newsletter;
+use CodelyTv\Model\User;
 
 final class NewsletterController
 {
     public function post(string $emailAddress): Newsletter
     {
-        UserController::ensureEmailIsValid($emailAddress);
+        User::ensureEmailIsValid($emailAddress);
 
         return new Newsletter($emailAddress);
     }

examples/php/php-user_email-03_move_method/src/Controller/UserController.php

@@ -5,47 +5,11 @@
 namespace CodelyTv\Controller;
 
 use CodelyTv\Model\User;
-use InvalidArgumentException;
 
 final class UserController
 {
     public function post(string $emailAddress): User
     {
-        self::ensureEmailIsValid($emailAddress);
-
         return new User($emailAddress);
     }
-
-    public static function ensureEmailIsValid(string $emailAddress): void
-    {
-        self::ensureEmailIsNotEmpty($emailAddress);
-        self::ensureEmailIsFormattedCorrectly($emailAddress);
-        self::ensureEmailHasCommonProvider($emailAddress);
-    }
-
-    private static function ensureEmailIsNotEmpty(string $emailAddress): void
-    {
-        if ('' === $emailAddress) {
-            throw new InvalidArgumentException('The email address is empty');
-        }
-    }
-
-    private static function ensureEmailIsFormattedCorrectly(string $emailAddress): void
-    {
-        if (!filter_var($emailAddress, FILTER_VALIDATE_EMAIL)) {
-            throw new InvalidArgumentException("The email address <$emailAddress> is not valid");
-        }
-    }
-
-    private static function ensureEmailHasCommonProvider(string $emailAddress): void
-    {
-        if (!self::emailHasCommonProvider($emailAddress)) {
-            throw new InvalidArgumentException("The email address <$emailAddress> has not a common provider");
-        }
-    }
-
-    private static function emailHasCommonProvider(string $emailAddress): bool
-    {
-        return strpos($emailAddress, '@yahoo') || strpos($emailAddress, '@gmail') || strpos($emailAddress, '@outlook');
-    }
 }

examples/php/php-user_email-03_move_method/src/Model/User.php

@@ -4,15 +4,52 @@
 
 namespace CodelyTv\Model;
 
+use InvalidArgumentException;
+
 final class User
 {
     private string $emailAddress;
 
     public function __construct(string $emailAddress)
     {
+        self::ensureEmailIsValid($emailAddress);
+
         $this->emailAddress = $emailAddress;
     }
 
+    public static function ensureEmailIsValid(string $emailAddress): void
+    {
+        self::ensureEmailIsNotEmpty($emailAddress);
+        self::ensureEmailIsFormattedCorrectly($emailAddress);
+        self::ensureEmailHasCommonProvider($emailAddress);
+    }
+
+    private static function ensureEmailIsNotEmpty(string $emailAddress): void
+    {
+        if ('' === $emailAddress) {
+            throw new InvalidArgumentException('The email address is empty');
+        }
+    }
+
+    private static function ensureEmailIsFormattedCorrectly(string $emailAddress): void
+    {
+        if (!filter_var($emailAddress, FILTER_VALIDATE_EMAIL)) {
+            throw new InvalidArgumentException("The email address <$emailAddress> is not valid");
+        }
+    }
+
+    private static function emailHasCommonProvider(string $emailAddress): bool
+    {
+        return strpos($emailAddress, '@yahoo') || strpos($emailAddress, '@gmail') || strpos($emailAddress, '@outlook');
+    }
+
+    private static function ensureEmailHasCommonProvider(string $emailAddress): void
+    {
+        if (!self::emailHasCommonProvider($emailAddress)) {
+            throw new InvalidArgumentException("The email address <$emailAddress> has not a common provider");
+        }
+    }
+
     public function emailAddress(): string
     {
         return $this->emailAddress;