[PHP] [StepStrategy] Move StepType hierarchy code constants to their parent class

Author: JavierCane

examples/php/php-step_strategy-02_replace_type_code_with_strategy/src/ExerciseStepType.php

@@ -8,6 +8,6 @@ final class ExerciseStepType extends StepType
 {
     public function code(): int
     {
-        return Step::EXERCISE_STEP_TYPE;
+        return StepType::EXERCISE_STEP_TYPE;
     }
 }

examples/php/php-step_strategy-02_replace_type_code_with_strategy/src/QuizStepType.php

@@ -15,6 +15,6 @@ public function __construct(array $quizQuestions)
 
     public function code(): int
     {
-        return Step::QUIZ_STEP_TYPE;
+        return StepType::QUIZ_STEP_TYPE;
     }
 }

examples/php/php-step_strategy-02_replace_type_code_with_strategy/src/Step.php

@@ -9,10 +9,6 @@ final class Step
     private const EXERCISE_STEP_DURATION_ESTIMATION_IN_MINUTES = 30;
     private const QUIZ_STEP_QUESTION_DURATION_ESTIMATION_IN_MINUTES = 3;
 
-    public const VIDEO_STEP_TYPE = 0;
-    public const QUIZ_STEP_TYPE = 1;
-    public const EXERCISE_STEP_TYPE = 2;
-
     private string   $title;
     private StepType $type;
     private ?int     $videoDurationInMinutes;
@@ -31,13 +27,13 @@ public function estimatedCompletionMinutes(): int
         $estimation = 0;
 
         switch ($this->type->code()) {
-            case self::VIDEO_STEP_TYPE:
+            case StepType::VIDEO_STEP_TYPE:
                 $estimation = $this->videoDurationInMinutes;
                 break;
-            case self::QUIZ_STEP_TYPE:
+            case StepType::QUIZ_STEP_TYPE:
                 $estimation = self::QUIZ_STEP_QUESTION_DURATION_ESTIMATION_IN_MINUTES * count($this->quizQuestions);
                 break;
-            case self::EXERCISE_STEP_TYPE:
+            case StepType::EXERCISE_STEP_TYPE:
                 $estimation = self::EXERCISE_STEP_DURATION_ESTIMATION_IN_MINUTES;
                 break;
         }

examples/php/php-step_strategy-02_replace_type_code_with_strategy/src/StepType.php

@@ -8,14 +8,18 @@
 
 abstract class StepType
 {
+    public const VIDEO_STEP_TYPE = 0;
+    public const QUIZ_STEP_TYPE = 1;
+    public const EXERCISE_STEP_TYPE = 2;
+
     public static function fromPrimitive(int $code, ?int $videoDurationInMinutes, ?array $quizQuestions)
     {
         switch ($code) {
-            case Step::VIDEO_STEP_TYPE:
+            case self::VIDEO_STEP_TYPE:
                 return new VideoStepType($videoDurationInMinutes);
-            case Step::QUIZ_STEP_TYPE:
+            case self::QUIZ_STEP_TYPE:
                 return new QuizStepType($quizQuestions);
-            case Step::EXERCISE_STEP_TYPE:
+            case self::EXERCISE_STEP_TYPE:
                 return new ExerciseStepType();
             default:
                 throw new InvalidArgumentException("Unrecognized Step type code");

examples/php/php-step_strategy-02_replace_type_code_with_strategy/src/VideoStepType.php

@@ -15,6 +15,6 @@ public function __construct(int $videoDurationInMinutes)
 
     public function code(): int
     {
-        return Step::VIDEO_STEP_TYPE;
+        return StepType::VIDEO_STEP_TYPE;
     }
 }