feat(tiered_pricing): 🔵 refactoring implementation second pricing range

Author: oflorez1381

exercises/tiered_pricing/solutions/oflorez/src/main/java/tv/codely/checkout/TieredPricing.java

@@ -6,12 +6,14 @@ public class TieredPricing {
     public static final int FIRST_RANGE_LOWER_LIMIT = 1;
     public static final int FIRST_RANGE_UPPER_LIMIT = 2;
 
+    public static final int SECOND_RANGE_UNIT_PRICE = 239;
+    public static final int SECOND_RANGE_LOWER_LIMIT = 3;
+    public static final int SECOND_RANGE_UPPER_LIMIT = 10;
+
     public int calculateTotalPrice(int amount_subscriptions) {
         if (amount_subscriptions >= FIRST_RANGE_LOWER_LIMIT && amount_subscriptions<= FIRST_RANGE_UPPER_LIMIT) return amount_subscriptions * FIRST_RANGE_UNIT_PRICE;
 
-        if (amount_subscriptions == 3) return 717;
-
-        if (amount_subscriptions == 4) return 956;
+        if (amount_subscriptions >= SECOND_RANGE_LOWER_LIMIT && amount_subscriptions<= SECOND_RANGE_UPPER_LIMIT) return amount_subscriptions * SECOND_RANGE_UNIT_PRICE;
 
         return 0;
     }

exercises/tiered_pricing/solutions/oflorez/src/test/java/tv/codely/checkout/TieredPricingShould.java

@@ -12,19 +12,22 @@ public class TieredPricingShould {
     @Test
 	void calculate_total_value_for_first_pricing_range() {
         var pricing = new TieredPricing();
-        var subscription = IntStream.rangeClosed(FIRST_RANGE_LOWER_LIMIT, FIRST_RANGE_UPPER_LIMIT).findAny().getAsInt();
-        assertEquals(FIRST_RANGE_UNIT_PRICE * subscription, pricing.calculateTotalPrice(subscription));
+        var subscription = retrieveSubscriptionGivenRange(FIRST_RANGE_LOWER_LIMIT, FIRST_RANGE_UPPER_LIMIT);
+        assertEquals(calculateTotalPriceExpected(FIRST_RANGE_UNIT_PRICE, subscription), pricing.calculateTotalPrice(subscription));
 	}
 
     @Test
-    void calculate_total_value_for_3_subscription() {
+    void calculate_total_value_for_second_pricing_range() {
         var pricing = new TieredPricing();
-        assertEquals(717, pricing.calculateTotalPrice(3));
+        var subscription = retrieveSubscriptionGivenRange(SECOND_RANGE_LOWER_LIMIT,SECOND_RANGE_UPPER_LIMIT);
+        assertEquals(calculateTotalPriceExpected(SECOND_RANGE_UNIT_PRICE, subscription), pricing.calculateTotalPrice(subscription));
     }
 
-    @Test
-    void calculate_total_value_for_4_subscription() {
-        var pricing = new TieredPricing();
-        assertEquals(956, pricing.calculateTotalPrice(4));
+    private int retrieveSubscriptionGivenRange(int lowerLimit, int upperLimit) {
+        return IntStream.rangeClosed(lowerLimit, upperLimit).findAny().getAsInt();
+    }
+
+    private int calculateTotalPriceExpected(int unitPrice, int subscription) {
+        return unitPrice * subscription;
     }
 }