feat(legacy-create-video): [golden-master] constructor inyection

Author: santakadev

exercises/legacy_create_video/solutions/codely_php-symfony_golden-master/src/AppBundle/Application/VideoCreator.php

@@ -4,9 +4,19 @@
 
 namespace AppBundle\Application;
 
+use Doctrine\DBAL\Connection;
+
 final class VideoCreator
 {
-    public function createVideo($title, $url, $courseId, object $connection): array
+    /** @var Connection */
+    private $connection;
+
+    public function __construct($connection)
+    {
+        $this->connection = $connection;
+    }
+
+    public function createVideo($title, $url, $courseId): array
     {
         $title = $this->sanitizeTitle($title);
 
@@ -17,11 +27,11 @@ public function createVideo($title, $url, $courseId, object $connection): array
                 )";
 
         // Prepare doctrine statement
-        $stmt = $connection->prepare($sql);
+        $stmt = $this->connection->prepare($sql);
         $stmt->execute();
 
         // IMPORTANT: Obtaining the video id. Take care, it's done without another query :)
-        $videoId = $connection->lastInsertId();
+        $videoId = $this->connection->lastInsertId();
         return array($title, $videoId);
     }
 

exercises/legacy_create_video/solutions/codely_php-symfony_golden-master/src/AppBundle/Controller/VideoController.php

@@ -11,14 +11,6 @@
  */
 class VideoController extends BaseController
 {
-    /** @var VideoCreator */
-    private $videoCreator;
-
-    public function __construct()
-    {
-        $this->videoCreator = new VideoCreator();
-    }
-
     /**
      * Method used to create a new video
      * @todo Validate the request
@@ -30,8 +22,9 @@ public function postVideoAction(Request $request)
         $url = $request->get('url');
         $courseId = $request->get('course_id');
         $connection = $this->getDoctrine()->getConnection();
+        $videoCreator = new VideoCreator($connection);
 
-        list($title, $videoId) = $this->videoCreator->createVideo($title, $url, $courseId, $connection);
+        list($title, $videoId) = $videoCreator->createVideo($title, $url, $courseId);
 
         // And we return the video created
         return [