fix: explicit default subscription tiers in tests

Author: adrianliz

exercises/tiered_pricing/solutions/adrianliz/java/src/main/java/tv/codely/checkout/TieredPricing.java

@@ -10,25 +10,6 @@ public TieredPricing(final List<SubscriptionTier> subscriptionTiers) {
         this.subscriptionTiers = subscriptionTiers;
     }
 
-    public TieredPricing() {
-        this(List.of(
-            new SubscriptionTier(
-                new SubscriptionTierRange(1, 2),
-                new SubscriptionTierPrice(299)),
-            new SubscriptionTier(
-                new SubscriptionTierRange(3, 10),
-                new SubscriptionTierPrice(239)),
-            new SubscriptionTier(
-                new SubscriptionTierRange(11, 25),
-                new SubscriptionTierPrice(219)),
-            new SubscriptionTier(
-                new SubscriptionTierRange(26, 50),
-                new SubscriptionTierPrice(199)),
-            new SubscriptionTier(
-                new SubscriptionTierRange(51, 100),
-                new SubscriptionTierPrice(149))));
-    }
-
     public double getTotalPrice(int subscriptions) {
         return subscriptionTiers.stream()
             .filter(subscriptionTier -> subscriptionTier.isInRange(subscriptions))

exercises/tiered_pricing/solutions/adrianliz/java/src/test/java/tv/codely/checkout/TieredPricingShould.java

@@ -3,12 +3,32 @@
 import static org.junit.jupiter.api.Assertions.assertEquals;
 import static org.junit.jupiter.api.Assertions.assertTrue;
 
+import java.util.List;
 import org.junit.jupiter.api.Test;
 import tv.codely.checkout.mother.IntegerMother;
 import tv.codely.checkout.mother.SubscriptionTierMother;
 
 public class TieredPricingShould {
 
+    private static List<SubscriptionTier> defaultSubscriptionTiers() {
+        return List.of(
+            new SubscriptionTier(
+                new SubscriptionTierRange(1, 2),
+                new SubscriptionTierPrice(299)),
+            new SubscriptionTier(
+                new SubscriptionTierRange(3, 10),
+                new SubscriptionTierPrice(239)),
+            new SubscriptionTier(
+                new SubscriptionTierRange(11, 25),
+                new SubscriptionTierPrice(219)),
+            new SubscriptionTier(
+                new SubscriptionTierRange(26, 50),
+                new SubscriptionTierPrice(199)),
+            new SubscriptionTier(
+                new SubscriptionTierRange(51, 100),
+                new SubscriptionTierPrice(149)));
+    }
+
     @Test
     void unit_test_example() {
         assertTrue(true);
@@ -29,7 +49,7 @@ void return_total_price_based_on_number_of_subscriptions() {
 
     @Test
     void return_total_price_for_1_subscription() {
-        final var tieredPricing = new TieredPricing();
+        final var tieredPricing = new TieredPricing(defaultSubscriptionTiers());
         final var expectedPrice = 299;
 
         final var totalPrice = tieredPricing.getTotalPrice(1);
@@ -38,7 +58,7 @@ void return_total_price_for_1_subscription() {
 
     @Test
     void return_total_price_for_3_subscriptions() {
-        final var tieredPricing = new TieredPricing();
+        final var tieredPricing = new TieredPricing(defaultSubscriptionTiers());
         final var expectedPrice = 239 * 3;
 
         final var totalPrice = tieredPricing.getTotalPrice(3);
@@ -47,7 +67,7 @@ void return_total_price_for_3_subscriptions() {
 
     @Test
     void return_total_price_for_11_subscriptions() {
-        final var tieredPricing = new TieredPricing();
+        final var tieredPricing = new TieredPricing(defaultSubscriptionTiers());
         final var expectedPrice = 219 * 11;
 
         final var totalPrice = tieredPricing.getTotalPrice(11);
@@ -56,7 +76,7 @@ void return_total_price_for_11_subscriptions() {
 
     @Test
     void return_total_price_for_26_subscriptions() {
-        final var tieredPricing = new TieredPricing();
+        final var tieredPricing = new TieredPricing(defaultSubscriptionTiers());
         final var expectedPrice = 199 * 26;
 
         final var totalPrice = tieredPricing.getTotalPrice(26);
@@ -65,7 +85,7 @@ void return_total_price_for_26_subscriptions() {
 
     @Test
     void return_total_price_for_51_subscriptions() {
-        final var tieredPricing = new TieredPricing();
+        final var tieredPricing = new TieredPricing(defaultSubscriptionTiers());
         final var expectedPrice = 149 * 51;
 
         final var totalPrice = tieredPricing.getTotalPrice(51);

exercises/tiered_pricing/solutions/adrianliz/java/src/test/java/tv/codely/checkout/mother/SubscriptionTierMother.java

@@ -18,15 +18,15 @@ public static SubscriptionTier create(
     public static List<SubscriptionTier> randoms() {
         final var subscriptionTierRanges = SubscriptionTierRangeMother.randoms();
         final var previousSubscriptionTierPrice = new AtomicReference<>(299D);
-        
+
         return subscriptionTierRanges.stream()
             .map(range -> {
                 final var subscriptionTierPrice =
                     DoubleMother.randomBetween(
                         previousSubscriptionTierPrice.get().intValue() - 60,
                         previousSubscriptionTierPrice.get().intValue() - 20);
                 previousSubscriptionTierPrice.set(subscriptionTierPrice);
-                return create(range, new SubscriptionTierPrice(subscriptionTierPrice));
+                return create(range, SubscriptionTierPriceMother.create(subscriptionTierPrice));
             })
             .toList();
     }

exercises/tiered_pricing/solutions/adrianliz/java/src/test/java/tv/codely/checkout/mother/SubscriptionTierPriceMother.java

@@ -7,8 +7,4 @@ public final class SubscriptionTierPriceMother {
     public static SubscriptionTierPrice create(final double value) {
         return new SubscriptionTierPrice(value);
     }
-
-    public static SubscriptionTierPrice randomBetween(final int min, final int max) {
-        return create(DoubleMother.randomBetween(min, max));
-    }
 }