[php][user_email-02_extract_method] NewsletterController calls UserController

Author: rgomezcasas

examples/php/php-user_email-02_extract_method/src/Controller/NewsletterController.php

@@ -5,23 +5,12 @@
 namespace CodelyTv\Controller;
 
 use CodelyTv\Model\Newsletter;
-use InvalidArgumentException;
 
 final class NewsletterController
 {
     public function post(string $emailAddress): Newsletter
     {
-        if ('' === $emailAddress) {
-            throw new InvalidArgumentException('The email address is empty');
-        }
-
-        if (!filter_var($emailAddress, FILTER_VALIDATE_EMAIL)) {
-            throw new InvalidArgumentException("The email address <$emailAddress> is not valid");
-        }
-
-        if (!(strpos($emailAddress, '@yahoo') || strpos($emailAddress, '@gmail') || strpos($emailAddress, '@outlook'))) {
-            throw new InvalidArgumentException("The email address <$emailAddress> has not a common provider");
-        }
+        UserController::ensureEmailIsValid($emailAddress);
 
         return new Newsletter($emailAddress);
     }

examples/php/php-user_email-02_extract_method/src/Controller/UserController.php

@@ -11,35 +11,40 @@ final class UserController
 {
     public function post(string $emailAddress): User
     {
-        $this->ensureEmailIsNotEmpty($emailAddress);
-        $this->ensureEmailIsFormattedCorrectly($emailAddress);
-        $this->ensureEmailHasCommonProvider($emailAddress);
+        self::ensureEmailIsValid($emailAddress);
 
         return new User($emailAddress);
     }
 
-    private function ensureEmailIsNotEmpty(string $emailAddress): void
+    public static function ensureEmailIsValid(string $emailAddress): void
+    {
+        self::ensureEmailIsNotEmpty($emailAddress);
+        self::ensureEmailIsFormattedCorrectly($emailAddress);
+        self::ensureEmailHasCommonProvider($emailAddress);
+    }
+
+    private static function ensureEmailIsNotEmpty(string $emailAddress): void
     {
         if ('' === $emailAddress) {
             throw new InvalidArgumentException('The email address is empty');
         }
     }
 
-    private function ensureEmailIsFormattedCorrectly(string $emailAddress): void
+    private static function ensureEmailIsFormattedCorrectly(string $emailAddress): void
     {
         if (!filter_var($emailAddress, FILTER_VALIDATE_EMAIL)) {
             throw new InvalidArgumentException("The email address <$emailAddress> is not valid");
         }
     }
 
-    private function ensureEmailHasCommonProvider(string $emailAddress): void
+    private static function ensureEmailHasCommonProvider(string $emailAddress): void
     {
-        if (!$this->emailHasCommonProvider($emailAddress)) {
+        if (!self::emailHasCommonProvider($emailAddress)) {
             throw new InvalidArgumentException("The email address <$emailAddress> has not a common provider");
         }
     }
 
-    private function emailHasCommonProvider(string $emailAddress): bool
+    private static function emailHasCommonProvider(string $emailAddress): bool
     {
         return strpos($emailAddress, '@yahoo') || strpos($emailAddress, '@gmail') || strpos($emailAddress, '@outlook');
     }