Add http error handling

Author: rgomezcasas

apps/main/tv/codely/apps/backoffice/backend/controller/courses/CoursesGetController.java

@@ -46,7 +46,7 @@ public List<HashMap<String, String>> index(
     }
 
     @Override
-    protected HashMap<Class<? extends DomainError>, HttpStatus> errorMapping() {
+    public HashMap<Class<? extends DomainError>, HttpStatus> errorMapping() {
         return null;
     }
 

apps/main/tv/codely/apps/backoffice/backend/controller/health_check/HealthCheckGetController.java

@@ -29,7 +29,7 @@ public HashMap<String, String> index() {
     }
 
     @Override
-    protected HashMap<Class<? extends DomainError>, HttpStatus> errorMapping() {
+    public HashMap<Class<? extends DomainError>, HttpStatus> errorMapping() {
         return null;
     }
 }

apps/main/tv/codely/apps/mooc/backend/config/MoocBackendServerConfiguration.java

@@ -0,0 +1,25 @@
+package tv.codely.apps.mooc.backend.config;
+
+import org.springframework.boot.web.servlet.FilterRegistrationBean;
+import org.springframework.context.annotation.Bean;
+import org.springframework.context.annotation.Configuration;
+import org.springframework.web.servlet.mvc.method.annotation.RequestMappingHandlerMapping;
+import tv.codely.shared.infrastructure.spring.ApiExceptionMiddleware;
+
+@Configuration
+public class MoocBackendServerConfiguration {
+    private final RequestMappingHandlerMapping mapping;
+
+    public MoocBackendServerConfiguration(RequestMappingHandlerMapping mapping) {
+        this.mapping = mapping;
+    }
+
+    @Bean
+    public FilterRegistrationBean<ApiExceptionMiddleware> basicHttpAuthMiddleware() {
+        FilterRegistrationBean<ApiExceptionMiddleware> registrationBean = new FilterRegistrationBean<>();
+
+        registrationBean.setFilter(new ApiExceptionMiddleware(mapping));
+
+        return registrationBean;
+    }
+}

apps/main/tv/codely/apps/mooc/backend/controller/courses/CourseGetController.java

@@ -38,7 +38,7 @@ public ResponseEntity<HashMap<String, Serializable>> index(@PathVariable String
     }
 
     @Override
-    protected HashMap<Class<? extends DomainError>, HttpStatus> errorMapping() {
+    public HashMap<Class<? extends DomainError>, HttpStatus> errorMapping() {
         return new HashMap<Class<? extends DomainError>, HttpStatus>() {{
             put(CourseNotExist.class, HttpStatus.NOT_FOUND);
         }};

apps/main/tv/codely/apps/mooc/backend/controller/courses/CoursesPutController.java

@@ -35,7 +35,7 @@ public ResponseEntity<String> index(
     }
 
     @Override
-    protected HashMap<Class<? extends DomainError>, HttpStatus> errorMapping() {
+    public HashMap<Class<? extends DomainError>, HttpStatus> errorMapping() {
         return null;
     }
 }

apps/main/tv/codely/apps/mooc/backend/controller/courses_counter/CoursesCounterGetController.java

@@ -29,7 +29,7 @@ public HashMap<String, Integer> index() throws QueryHandlerExecutionError {
     }
 
     @Override
-    protected HashMap<Class<? extends DomainError>, HttpStatus> errorMapping() {
+    public HashMap<Class<? extends DomainError>, HttpStatus> errorMapping() {
         return null;
     }
 }

apps/main/tv/codely/apps/mooc/backend/controller/health_check/HealthCheckGetController.java

@@ -29,7 +29,7 @@ public HashMap<String, String> index() {
     }
 
     @Override
-    protected HashMap<Class<? extends DomainError>, HttpStatus> errorMapping() {
+    public HashMap<Class<? extends DomainError>, HttpStatus> errorMapping() {
         return null;
     }
 }

apps/main/tv/codely/apps/mooc/backend/controller/notifications/NewsletterNotificationPutController.java

@@ -34,7 +34,7 @@ public ResponseEntity<String> index(
     }
 
     @Override
-    protected HashMap<Class<? extends DomainError>, HttpStatus> errorMapping() {
+    public HashMap<Class<? extends DomainError>, HttpStatus> errorMapping() {
         return null;
     }
 }

apps/test/tv/codely/apps/mooc/backend/controller/courses/CourseGetControllerShould.java

@@ -14,6 +14,14 @@ void find_an_existing_course() throws Exception {
         assertResponse(String.format("/courses/%s", id), 200, body);
     }
 
+    @Test
+    void no_find_a_non_existing_course() throws Exception {
+        String id   = "4ecc0cb3-05b2-4238-b7e1-1fbb0d5d3661";
+        String body = "{\"error_code\": \"course_not_exist\", \"message\": \"The course <4ecc0cb3-05b2-4238-b7e1-1fbb0d5d3661> doesn't exist\"}";
+
+        assertResponse(String.format("/courses/%s", id), 404, body);
+    }
+
     private void givenThereIsACourse(String id, String body) throws Exception {
         assertRequestWithBody("PUT", String.format("/courses/%s", id), body, 201);
     }

src/shared/main/tv/codely/shared/infrastructure/spring/ApiController.java

@@ -28,5 +28,5 @@ protected <R> R ask(Query query) throws QueryHandlerExecutionError {
         return queryBus.ask(query);
     }
 
-    abstract protected HashMap<Class<? extends DomainError>, HttpStatus> errorMapping();
+    abstract public HashMap<Class<? extends DomainError>, HttpStatus> errorMapping();
 }