Skip to content

Sheffield | 25-ITP-SEP | Declan Williams | Sprint 1 | structuring and testing data #876

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 12 commits into
base: main
Choose a base branch
from
Open

Sheffield | 25-ITP-SEP | Declan Williams | Sprint 1 | structuring and testing data #876

wants to merge 12 commits into from

Conversation

@CatchingKiyoko
Copy link

@CatchingKiyoko CatchingKiyoko commented Nov 13, 2025 •
edited
Loading

Learners, PR Template

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

  1. refactored and implemented code
  2. answered questions in comments

@CatchingKiyoko
answered question in comment
56e872f
@CatchingKiyoko
implement initials extraction and logs individual characters
346b377
@CatchingKiyoko
Implement extraction of dir and ext parts from filePath using .slice
fcff6a6
@CatchingKiyoko
refactor: enhance comments for clarity on random number generation logic
fd58796
@CatchingKiyoko
refactor comments to clarify instructions for the first activity
ceb590d
@CatchingKiyoko
changed age variable declaration from const to let for reassignment
d41194c
@CatchingKiyoko
reorder code to declare cityOfBirth before usage in console.log to so…
7ae8d3a 
…lve the error
@CatchingKiyoko
refactored and fixed the error so that the cardNumber is now correctl…
8176900 
…y converted into a string so that .Slice can be used and produce no errors.
@CatchingKiyoko
refactored the code so that it doesn't give the syntax error indentif…
1b5ea36 
…ier is directly after a number.
@CatchingKiyoko
fix: correct syntax error in priceAfterOneYear conversion and update …
1dd8029 
…comments
@CatchingKiyoko
answered questions on comments for clarity on variable declarations a…
a6d27f3 
…nd calculations in time format code
@CatchingKiyoko
answered question in comments on price conversion logic and the purpo…
4db1ee4 
…se behind the steps
@github-actions
Copy link

github-actions bot commented Nov 13, 2025

Your PR description contained template fields which weren't filled in.

Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

@CatchingKiyoko CatchingKiyoko added 📅 Sprint 1 Assigned during Sprint 1 of this module Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Module-Structuring-And-Testing-Data The name of the module. labels Nov 14, 2025
cjyuan
cjyuan reviewed Nov 15, 2025
View reviewed changes
Copy link
Contributor

@cjyuan cjyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good.

You mentioned Jest test in the PR description, but I don't see any Jest test on this branch though. Can you update the PR description accordingly?

@cjyuan cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Nov 15, 2025
@CatchingKiyoko CatchingKiyoko added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Nov 15, 2025
@cjyuan cjyuan added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Nov 15, 2025
@CatchingKiyoko CatchingKiyoko mentioned this pull request Nov 22, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cjyuan cjyuan cjyuan left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

Complete Volunteer to add when work is complete and all review comments have been addressed. Module-Structuring-And-Testing-Data The name of the module. 📅 Sprint 1 Assigned during Sprint 1 of this module

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@CatchingKiyoko @cjyuan