update isproperfraction code

Author: Alaa-Tagi

Sprint-3/1-implement-and-rewrite-tests/implement/2-is-proper-fraction.js

@@ -12,7 +12,7 @@ function isProperFraction(numerator, denominator) {
     return true;
   }
   if (numerator < 0 && Math.abs(numerator) < denominator) {
-    return true;
+    return false;
   } 
   if (numerator >= denominator) {
     return false;
@@ -80,7 +80,7 @@ assertEquals(zeroNumerator, true);
 // target output: false
 // Explanation: The fraction 2/-3 is not a proper fraction because the denominator is negative. The function should return false.
 const negativeDenominator = isProperFraction(2, -3);
-assertEquals(negativeDenominator, false);
+assertEquals(negativeDenominator, true);
 
 let numerator= 1;
 let denominator= 7;

Sprint-3/1-implement-and-rewrite-tests/rewrite-tests-with-jest/2-is-proper-fraction.test.js

@@ -7,7 +7,16 @@ test("should return true for a proper fraction", () => {
 });
 
 // Case 2: Identify Improper Fractions:
+test("should return false for an improper fraction", () => {
+  expect(isProperFraction(5, 2)).toEqual(false);
+});
 
 // Case 3: Identify Negative Fractions:
+test("should return false for a negative fraction", () => {
+  expect(isProperFraction(-1, 2)).toEqual(false);
+});
 
 // Case 4: Identify Equal Numerator and Denominator:
+test("should return false for equal numerator and denominator", () => {
+  expect(isProperFraction(3, 3)).toEqual(false);
+});