Update format-time.js

Author: Alaa-Tagi

Sprint-2/5-stretch-extend/format-time.js

@@ -2,6 +2,7 @@
 // Make sure to do the prep before you do the coursework
 // Your task is to write tests for as many different groups of input data or edge cases as you can, and fix any bugs you find.
 
+// The main function:
 function formatAs12HourClock(time) {
   const hours = Number(time.slice(0, 2));
   if (hours > 12) {
@@ -10,16 +11,106 @@ function formatAs12HourClock(time) {
   return `${time} am`;
 }
 
+// Tests:
 const currentOutput = formatAs12HourClock("08:00");
 const targetOutput = "08:00 am";
 console.assert(
   currentOutput === targetOutput,
   `current output: ${currentOutput}, target output: ${targetOutput}`
-);
+); // It's output is correct
 
 const currentOutput2 = formatAs12HourClock("23:00");
 const targetOutput2 = "11:00 pm";
 console.assert(
   currentOutput2 === targetOutput2,
   `current output: ${currentOutput2}, target output: ${targetOutput2}`
-);
+); // It's output is correct
+
+const currentOutput3 = formatAs12HourClock("12:00");
+const targetOutput3 = "12:00 pm";
+console.assert(
+  currentOutput3 === targetOutput3,
+  `current output: ${currentOutput3}, target output: ${targetOutput3}`
+); // It's output is incorrect because it returns "12:00 am" instead of "12:00 pm"
+
+const currentOutput4 = formatAs12HourClock("00:00");
+const targetOutput4 = "12:00 am";
+console.assert(
+  currentOutput4 === targetOutput4,
+  `current output: ${currentOutput4}, target output: ${targetOutput4}`
+); // It's output is incorrect because it returns "00:00 am" instead of "12:00 am"
+
+const currentOutput5 = formatAs12HourClock("15:30");
+const targetOutput5 = "3:30 pm";
+console.assert(
+  currentOutput5 === targetOutput5,
+  `current output: ${currentOutput5}, target output: ${targetOutput5}`
+); // It's output is incorrect because it returns "15:00 pm" instead of "3:30 pm"
+
+const currentOutput6 = formatAs12HourClock("11:45");
+const targetOutput6 = "11:45 am";
+console.assert(
+  currentOutput6 === targetOutput6,
+  `current output: ${currentOutput6}, target output: ${targetOutput6}`
+); // It's output is correct
+
+//Fixing the function:
+function formatAs12HourClockFixed(time) {
+  const hours = Number(time.slice(0, 2));
+  const minutes = time.slice(3, 5);
+  let period = "am";
+
+  if (hours === 0) {
+    return `12:${minutes} am`;
+  }
+  if (hours === 12) {
+    period = "pm";
+  }
+  if (hours > 12) {
+    return `${hours - 12}:${minutes} pm`;
+  }
+  return `${hours}:${minutes} ${period}`;
+}
+
+// Re-testing :
+const currentOutput1 = formatAs12HourClockFixed("08:00");
+const targetOutput1 = "8:00 am";
+console.assert(
+  currentOutput1 === targetOutput1,
+  `current output: ${currentOutput1}, target output: ${targetOutput1}`
+); // It's output is correct
+
+const currentOutput2 = formatAs12HourClockFixed("23:00");
+const targetOutput2 = "11:00 pm";
+console.assert(
+  currentOutput2 === targetOutput2,
+  `current output: ${currentOutput2}, target output: ${targetOutput2}`
+); // It's output is correct
+
+const currentOutput3 = formatAs12HourClockFixed("12:00");
+const targetOutput3 = "12:00 pm";
+console.assert(
+  currentOutput3 === targetOutput3,
+  `current output: ${currentOutput3}, target output: ${targetOutput3}`
+); // It's output is correct
+
+const currentOutput4 = formatAs12HourClockFixed("00:00");
+const targetOutput4 = "12:00 am";
+console.assert(
+  currentOutput4 === targetOutput4,
+  `current output: ${currentOutput4}, target output: ${targetOutput4}`
+); // It's output is correct
+
+const currentOutput5 = formatAs12HourClockFixed("15:30");
+const targetOutput5 = "3:30 pm";
+console.assert(
+  currentOutput5 === targetOutput5,
+  `current output: ${currentOutput5}, target output: ${targetOutput5}`
+); // It's output is correct
+
+const currentOutput6 = formatAs12HourClockFixed("11:45");
+const targetOutput6 = "11:45 am";
+console.assert(
+  currentOutput6 === targetOutput6,
+  `current output: ${currentOutput6}, target output: ${targetOutput6}`
+); // It's output is correct