Implemented a function isProperFraction

Author: i786m

Sprint-3/1-implement-and-rewrite-tests/implement/2-is-proper-fraction.js

@@ -8,9 +8,18 @@
 // write one test at a time, and make it pass, build your solution up methodically
 
 function isProperFraction(numerator, denominator) {
-  if (numerator < denominator) {
+  if (Math.abs(numerator) < Math.abs(denominator)) {
     return true;
   }
+  if (numerator >= denominator) {
+    return false;
+  }
+  if(numerator == 0){
+    return true;
+  }
+  if (denominator === 0) {
+    return false;
+  }
 }
 
 // The line below allows us to load the isProperFraction function into tests in other files.
@@ -47,13 +56,48 @@ assertEquals(improperFraction, false);
 // Explanation: The fraction -4/7 is a proper fraction because the absolute value of the numerator (4) is less than the denominator (7). The function should return true.
 const negativeFraction = isProperFraction(-4, 7);
 // ====> complete with your assertion
-
+assertEquals(negativeFraction, true);
 // Equal Numerator and Denominator check:
 // Input: numerator = 3, denominator = 3
 // target output: false
 // Explanation: The fraction 3/3 is not a proper fraction because the numerator is equal to the denominator. The function should return false.
 const equalFraction = isProperFraction(3, 3);
 // ====> complete with your assertion
-
+assertEquals(equalFraction, false);
 // Stretch:
 // What other scenarios could you test for?
+// Zero Numerator check:
+// Input: numerator = 0, denominator = 5
+// target output: true
+// Explanation: The fraction 0/5 is a proper fraction because the numerator (0) is less than the denominator (5). The function should return true.
+const zeroNumerator = isProperFraction(0, 5);
+// ====> complete with your assertion
+assertEquals(zeroNumerator, true);
+// Zero Denominator check:
+// Input: numerator = 4, denominator = 0 
+// target output: false
+// Explanation: The fraction 4/0 is undefined because division by zero is not allowed. The function should return false.
+const zeroDenominator = isProperFraction(4, 0);
+// ====> complete with your assertion
+assertEquals(zeroDenominator, false);
+// Negative Denominator check:
+// Input: numerator = 3, denominator = -5
+// target output: true
+// Explanation: The fraction 3/-5 is a proper fraction because the absolute value of the numerator (3) is less than the absolute value of the denominator (5). The function should return true.
+const negativeDenominator = isProperFraction(3, -5);
+// ====> complete with your assertion
+assertEquals(negativeDenominator, true);
+// Both Negative check:
+// Input: numerator = -2, denominator = -6
+// target output: true
+// Explanation: The fraction -2/-6 is a proper fraction because the absolute value of the numerator (2) is less than the absolute value of the denominator (6). The function should return true.
+const bothNegative = isProperFraction(-2, -6);
+// ====> complete with your assertion
+assertEquals(bothNegative, true);
+// Zero Numerator and Denominator check:
+// Input: numerator = 0, denominator = 0
+// target output: false
+// Explanation: The fraction 0/0 is undefined. The function should return false.
+const zeroNumeratorDenominator = isProperFraction(0, 0);
+// ====> complete with your assertion
+assertEquals(zeroNumeratorDenominator, false);