feat(refactoring): removing obsolete sniffs

Author: Mte90

CodeatCodingStandard/ruleset.xml

@@ -17,14 +17,14 @@
     <rule ref="Generic.CodeAnalysis.EmptyStatement"/>
     <rule ref="Generic.Commenting.Todo"/>
     <rule ref="Generic.Commenting.DocComment"/>
-    <rule ref="Generic.Commenting.DocComment.TagValueIndent"/>
     <rule ref="Generic.Commenting.DocComment.ParamNotFirst"/>
     <rule ref="Generic.Commenting.DocComment.ParamGroup"/>
     <rule ref="Generic.Commenting.DocComment.NonParamGroup"/>
     <rule ref="Generic.Commenting.DocComment.TagsNotGrouped"/>
+    <rule ref="Generic.Commenting.DocComment.TagValueIndent"/>
     <rule ref="Generic.Commenting.DocComment.ContentAfterOpen"/>
-    <rule ref="Generic.Commenting.DocComment.SpacingBeforeShort"/>
     <rule ref="Generic.Commenting.DocComment.ContentBeforeClose"/>
+    <rule ref="Generic.Commenting.DocComment.SpacingBeforeShort"/>
     <!-- Check for PHP Parse errors. -->
     <rule ref="Generic.PHP.Syntax"/>
     <!-- Check for file encoding problems. -->
@@ -33,25 +33,28 @@
     <rule ref="Generic.Commenting.Fixme"/>
     <rule ref="Zend.Files.ClosingTag"/>
     <rule ref="Squiz.Commenting">
-        <exclude name="Squiz.Commenting.FileComment.WrongStyle"/>
-        <exclude name="Squiz.Commenting.FileComment.SpacingAfterOpen"/>
         <exclude name="Squiz.Commenting.PostStatementComment.Found"/>
         <exclude name="Squiz.Commenting.LongConditionClosingComment.Missing"/>
         <exclude name="Squiz.Commenting.LongConditionClosingComment.Invalid"/>
         <exclude name="Squiz.Commenting.FunctionComment.Missing"/>
         <exclude name="Squiz.Commenting.FunctionCommentThrowTag.Missing"/>
         <exclude name="Squiz.Commenting.FileComment.SpacingAfterOpen"/>
         <exclude name="Squiz.Commenting.FileComment.SpacingAfterComment"/>
+        <exclude name="Squiz.Commenting.FileComment.WrongStyle"/>
+        <exclude name="Squiz.Commenting.FileComment.SpacingAfterOpen"/>
         <exclude name="Squiz.Commenting.BlockComment.NoEmptyLineBefore"/>
     </rule>
     <rule ref="Squiz.PHP">
-        <exclude name="Squiz.PHP.DisallowMultipleAssignments.Found"/>
         <exclude name="Squiz.PHP.GlobalKeyword.NotAllowed"/>
+        <exclude name="Squiz.PHP.DisallowMultipleAssignments.Found"/>
         <exclude name="Squiz.PHP.DisallowBooleanStatement.Found"/>
         <exclude name="Squiz.PHP.DisallowInlineIf.Found"/>
         <exclude name="Squiz.PHP.DisallowComparisonAssignment.AssignedComparison"/>
         <exclude name="Squiz.PHP.ForbiddenFunctions.Found"/>
     </rule>
+    <rule ref="Squiz.PHP.DisallowSizeFunctionsInLoops">
+        <type>warning</type>
+    </rule>
     <rule ref="Squiz.WhiteSpace.FunctionSpacing">
         <properties>
             <property name="spacing" value="1"/>
@@ -70,13 +73,10 @@
     <rule ref="PEAR.NamingConventions">
         <exclude name="PEAR.NamingConventions.ValidClassName.Invalid"/>
         <exclude name="PEAR.NamingConventions.ValidVariableName.PrivateNoUnderscore"/>
+        <exclude name="PEAR.NamingConventions.ValidVariableName.PrivateNoUnderscore"/>
         <exclude name="PEAR.NamingConventions.ValidFunctionName.ScopeNotCamelCaps"/>
         <exclude name="PEAR.NamingConventions.ValidFunctionName.FunctionNoCapital"/>
         <exclude name="PEAR.NamingConventions.ValidFunctionName.FunctionNameInvalid"/>
-    </rule>
-    <rule ref="PEAR.NamingConventions">
-        <exclude name="PEAR.NamingConventions.ValidClassName.Invalid"/>
-        <exclude name="PEAR.NamingConventions.ValidVariableName.PrivateNoUnderscore"/>
         <exclude name="PEAR.NamingConventions.ValidFunctionName.PrivateNoUnderscore"/>
     </rule>
     <rule ref="PEAR.Files.IncludingFile">
@@ -97,9 +97,8 @@
         <exclude name="WordPress.Arrays.ArrayKeySpacingRestrictions.NoSpacesAroundArrayKeys"/>
         <exclude name="WordPress.Arrays.ArrayKeySpacingRestrictions.SpacesAroundArrayKeys"/>
         <exclude name="WordPress.Arrays.ArrayDeclarationSpacing.AssociativeArrayFound"/>
-        <exclude name="WordPress.Arrays.ArrayIndentation.CloseBraceNotAligned"/>
-        <exclude name="WordPress.Arrays.ArrayIndentation.ItemNotAligned"/>
         <exclude name="WordPress.Arrays.ArrayDeclaration.NoComma"/>
+        <exclude name="WordPress.Arrays.ArrayIndentation.CloseBraceNotAligned"/>
         <exclude name="WordPress.Files.FileName.InvalidClassFileName"/>
         <exclude name="WordPress.Files.FileName.NotHyphenatedLowercase"/>
         <exclude name="WordPress.PHP.YodaConditions"/>
@@ -114,20 +113,23 @@
     <rule ref="Generic.CodeAnalysis.UselessOverridingMethod.Found">
         <severity>0</severity>
     </rule>
-    <rule ref="WordPress.PHP.StrictInArray"/>
+    <rule ref="Generic.CodeAnalysis.EmptyStatement">
+        <type>warning</type>
+    </rule>
+    <rule ref="Wordpress-Docs">
+        <exclude name="Squiz.Commenting.InlineComment.InvalidEndChar"/>
+    </rule>
+    <rule ref="WordPress.NamingConventions.PrefixAllGlobals"/>
     <rule ref="WordPress.DB.PreparedSQLPlaceholders"/>
     <rule ref="WordPress.DB.RestrictedFunctions"/>
     <rule ref="WordPress.DB.RestrictedClasses"/>
     <rule ref="WordPress.PHP.DevelopmentFunctions"/>
     <rule ref="WordPress.PHP.DiscouragedPHPFunctions"/>
+    <rule ref="WordPress.PHP.StrictInArray"/>
     <rule ref="WordPress.WP.AlternativeFunctions"/>
     <rule ref="WordPress.WP.DiscouragedConstants"/>
     <rule ref="WordPress.WP.DiscouragedFunctions"/>
     <rule ref="WordPress.WP.EnqueuedResources"/>
-    <rule ref="WordPress.NamingConventions.PrefixAllGlobals"/>
-    <rule ref="Wordpress-Docs">
-        <exclude name="Squiz.Commenting.InlineComment.InvalidEndChar"/>
-    </rule>
     <rule ref="WordPress.WP.DeprecatedClasses">
         <properties>
             <property name="minimum_supported_version" value="5.3"/>
@@ -147,12 +149,6 @@
     <rule ref="WordPress.Security.ValidatedSanitizedInput">
         <type>warning</type>
     </rule>
-    <rule ref="Generic.CodeAnalysis.EmptyStatement">
-        <type>warning</type>
-    </rule>
-    <rule ref="Squiz.PHP.DisallowSizeFunctionsInLoops">
-        <type>warning</type>
-    </rule>
     <rule ref="WordPress.WP.I18n">
         <properties>
             <property name="text_domain" type="array" value="glossary-by-codeat,woo-fiscalita-italiana,genesis"/>
@@ -168,7 +164,6 @@
         <exclude name="SlevomatCodingStandard.Whitespaces.DuplicateSpaces"/>
         <exclude name="SlevomatCodingStandard.Files.TypeNameMatchesFileName"/>
         <exclude name="SlevomatCodingStandard.Files.LineLength.LineTooLong"/>
-        <exclude name="SlevomatCodingStandard.Commenting.DisallowCommentAfterCode.DisallowedCommentAfterCode"/>
         <exclude name="SlevomatCodingStandard.ControlStructures.DisallowEmpty.DisallowedEmpty"/>
         <exclude name="SlevomatCodingStandard.ControlStructures.NewWithParentheses.MissingParentheses"/>
         <exclude name="SlevomatCodingStandard.ControlStructures.DisallowYodaComparison.DisallowedYodaComparison"/>
@@ -181,6 +176,7 @@
         <exclude name="SlevomatCodingStandard.Variables.DisallowSuperGlobalVariable.DisallowedSuperGlobalVariable"/>
         <exclude name="SlevomatCodingStandard.Commenting.RequireOneLineDocComment.MultiLineDocComment"/>
         <exclude name="SlevomatCodingStandard.Commenting.RequireOneLinePropertyDocComment.MultiLinePropertyComment"/>
+        <exclude name="SlevomatCodingStandard.Commenting.DisallowCommentAfterCode.DisallowedCommentAfterCode"/>
     </rule>
     <!-- Require php 7.1 as minimum for object that is not support on php 7.1 below -->
     <rule ref="SlevomatCodingStandard.TypeHints.ParameterTypeHint">