Merge pull request #3 from Code-Hex/add/eslint

add eslint

Author: Code-Hex

.eslintrc.json

@@ -0,0 +1,40 @@
+{
+  "env": {
+    "node": true,
+    "es2021": true
+  },
+  "extends": [
+    "eslint:recommended",
+    "plugin:@typescript-eslint/recommended"
+  ],
+  "parser": "@typescript-eslint/parser",
+  "parserOptions": {
+    "ecmaVersion": "latest"
+  },
+  "plugins": [
+    "@typescript-eslint"
+  ],
+  "rules": {
+    "@typescript-eslint/no-explicit-any": "off"
+  },
+  "overrides": [
+    {
+      "files": [
+        "*.spec.ts"
+      ],
+      "env": {
+        "jest": true
+      },
+      "rules": {
+        "no-unused-vars": "off",
+        "@typescript-eslint/no-unused-vars": "off",
+        "import/no-extraneous-dependencies": "off"
+      }
+    }
+  ],
+  "ignorePatterns": [
+    "dist",
+    "node_modules",
+    "gen"
+  ]
+}

.github/workflows/ci.yml

@@ -24,3 +24,32 @@ jobs:
       - run: yarn test
         env:
             CI: true
+  eslint:
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v2
+      - name: Setup Node
+        uses: actions/setup-node@v2
+        with:
+          node-version: 17
+      - name: Cache Yarn
+        uses: actions/cache@v2
+        with:
+          path: '**/node_modules'
+          key: ${{ runner.os }}-yarn-${{ hashFiles('yarn.lock') }}
+          restore-keys: |
+            ${{ runner.os }}-yarn-
+      - run: yarn install --frozen-lockfile
+      - run: yarn lint-fix
+      - name: Auto commit fixed code
+        id: auto-commit-action
+        uses: stefanzweifel/git-auto-commit-action@v4
+        with:
+          commit_message: Apply auto lint-fix changes
+          branch: ${{ github.head_ref }}
+      - name: eslint
+        if: steps.auto-commit-action.outputs.changes_detected == 'false'
+        uses: reviewdog/action-eslint@v1
+        with:
+          level: warning
+          reporter: github-pr-review

package.json

@@ -23,6 +23,8 @@
     "build": "run-p build:*",
     "build:main": "tsc -p tsconfig.main.json",
     "build:module": "tsc -p tsconfig.module.json",
+    "lint": "eslint --ext .ts .",
+    "lint-fix": "eslint --fix --ext .ts .",
     "generate": "run-p build:* && graphql-codegen",
     "prepublish": "run-p build:*"
   },
@@ -47,6 +49,9 @@
     "@graphql-codegen/typescript": "^2.4.2",
     "@tsconfig/recommended": "^1.0.1",
     "@types/jest": "^27.4.0",
+    "@typescript-eslint/eslint-plugin": "^5.10.0",
+    "@typescript-eslint/parser": "^5.10.0",
+    "eslint": "^8.7.0",
     "jest": "^27.4.7",
     "npm-run-all": "^4.1.5",
     "ts-jest": "^27.1.3",

src/config.ts

@@ -115,23 +115,3 @@ export interface ValidationSchemaPluginConfig extends TypeScriptPluginConfig {
    */
   directives?: DirectiveConfig;
 }
-
-interface YupSchemaPluginConfig {
-  /**
-   * @description Generates yup schema as strict.
-   * @default false
-   * @see https://github.com/jquense/yup#schemastrictenabled-boolean--false-schema
-   *
-   * @exampleMarkdown
-   * ```yml
-   * generates:
-   *   path/to/file.ts:
-   *     plugins:
-   *       - graphql-codegen-validation-schema
-   *     config:
-   *       yup:
-   *         strict: true
-   * ```
-   */
-  strict?: boolean;
-}

src/index.ts

@@ -23,6 +23,7 @@ export const plugin: PluginFunction<
     leave: visitor,
   });
 
+  // eslint-disable-next-line @typescript-eslint/ban-ts-comment
   // @ts-ignore
   const generated = result.definitions.filter((def) => typeof def === "string");
 

tests/regexp.spec.ts

@@ -14,7 +14,9 @@ describe("isConvertableRegexp", () => {
       "/hello/y",
       "/hello/dgimsuy",
       `/\\w+\\s/g`,
+      // eslint-disable-next-line no-useless-escape
       `/^[a-z]+:[\\\/]$/i`,
+      // eslint-disable-next-line no-useless-escape
       `/^(?:\d{3}|\(\d{3}\))([-\/\.])\d{3}\\1\d{4}$/`,
     ])("%s", (maybeRegexp) => {
       expect(isConvertableRegexp(maybeRegexp)).toBeTruthy();