fix: added @cocreate/utils for queryFrameSelectorAll

frankpagan · frankpagan · commit 6118e91b1828 · 2022-02-03T14:12:46.000Z
diff --git a/demo/index.html b/demo/index.html
@@ -3,7 +3,7 @@
   <head>
 	<title>Conditional Logic | CoCreateJS</title>
 	<!-- CoCreate Favicon -->
-    <link rel="icon" href="https://cdn.cocreate.app/favicon.ico" type="image/ico" sizes="16x16">
+    <link rel="icon" href="https://cdn.cocreate.app/favicon.ico" type="image/ico" sizes="16x16" parse="true">
   </head>
   <body>
 	  
@@ -127,6 +127,12 @@ <h6 style='color:blue'>7 example  SELECT (show multiples)</h6>
     <div class='ctr_check1' class="hidden"> CHECK4</div>
     <div id='ctr_other1' class="hidden"> OTHER</div>
 
+    <div hide='iframe;,#testdiv1' show='iframe;#testdiv1,#testdiv1'>
+        <div class="test">click me</div>
+    </div>
+    
+    <iframe srcDoc="<div id='testdiv1'> will toggle </div>"></iframe>
+    <div id='testdiv1' class=""> will toggle </div>
 
      
     <!--<script src="../dist/CoCreate-conditional-logic.js"></script>-->
diff --git a/package.json b/package.json
@@ -64,6 +64,6 @@
     "@cocreate/actions": "^1.3.28",
     "@cocreate/docs": "^1.2.65",
     "@cocreate/observer": "^1.4.0",
-    "@cocreate/utils": "^1.5.0"
+    "@cocreate/utils": "^1.6.0"
   }
 }
diff --git a/src/index.js b/src/index.js
@@ -7,6 +7,7 @@
 /*globals CustomEvent, CoCreate*/
 import observer from '@cocreate/observer';
 import action from '@cocreate/actions';
+import {queryFrameSelectorAll} from '@cocreate/utils';
 
 function init() {
 	let elements = document.querySelectorAll(`[show],[hide]`);
@@ -46,10 +47,10 @@ function selectShowHideEle(e) {
 		if (value != '') {
 			var show = opt.getAttribute('show');
 			if (typeof show != 'undefined') {
-				for (let el of document.querySelectorAll(show))
+				for (let el of queryFrameSelectorAll(show))
 					el.classList.add('hidden');
 				if (opt.selected === true) {
-					for (let el of document.querySelectorAll(show))
+					for (let el of queryFrameSelectorAll(show))
 						el.classList.remove('hidden');
 				}
 			}
@@ -72,12 +73,12 @@ function clickShowHideEle(e) {
 
 			show = radio.getAttribute('show');
 
-			for (let el of document.querySelectorAll(show)) {
+			for (let el of queryFrameSelectorAll(show)) {
 				el.classList.add('hidden');
 			}
 
 			if (radio.checked) {
-				for (let el of document.querySelectorAll(show))
+				for (let el of queryFrameSelectorAll(show))
 					el.classList.remove('hidden');
 			}
 		}
@@ -86,14 +87,14 @@ function clickShowHideEle(e) {
 
 		let updated_els = [];
 
-		for (let el of document.querySelectorAll(show)) {
+		for (let el of queryFrameSelectorAll(show)) {
 			if (el.classList.contains('hidden')) {
 				el.classList.remove('hidden');
 				updated_els.push(el);
 			}
 		}
 
-		for (let el of document.querySelectorAll(hide)) {
+		for (let el of queryFrameSelectorAll(hide)) {
 			let existEqual = false;
 			for (let uel of updated_els) {
 				if (el.isEqualNode(uel)) {

Original file line number	Diff line number	Diff line change
`@@ -64,6 +64,6 @@`
`64`	`64`	`"@cocreate/actions": "^1.3.28",`
`65`	`65`	`"@cocreate/docs": "^1.2.65",`
`66`	`66`	`"@cocreate/observer": "^1.4.0",`
`67`		`- "@cocreate/utils": "^1.5.0"`
	`67`	`+ "@cocreate/utils": "^1.6.0"`
`68`	`68`	`}`
`69`	`69`	`}`