remove support for EOL rubies/activerecord (#400)

Author: seuros

.github/workflows/ci.yml

@@ -2,20 +2,28 @@
 name: CI
 
 on:
-  - push
-  - pull_request
+  pull_request:
+    branches:
+      - master
 
 jobs:
   rspec:
-    runs-on: ubuntu-20.04
-
+    runs-on: ubuntu-latest
     services:
+      mysql:
+        image: mysql/mysql-server:8.0.30
+        ports:
+          - "3306:3306"
+        env:
+          MYSQL_ROOT_PASSWORD: root
+          MYSQL_DATABASE: closure_tree_test
+          MYSQL_ROOT_HOST: '%'
       postgres:
         image: 'postgres:13'
         ports: ['5432:5432']
         env:
           POSTGRES_PASSWORD: postgres
-          POSTGRES_DB: closure_tree
+          POSTGRES_DB: closure_tree_test
         options: >-
           --health-cmd pg_isready
           --health-interval 10s
@@ -28,40 +36,15 @@ jobs:
         ruby:
           - '3.0'
           - '2.7'
-          - '2.6'
-          - '2.5'
         rails:
           - activerecord_7.0
           - activerecord_6.1
           - activerecord_6.0
-          - activerecord_5.2
-          - activerecord_5.1
-          - activerecord_5.0
-          - activerecord_4.2
           - activerecord_edge
         adapter:
-          - sqlite3
-          - mysql2
-          - postgresql
-        exclude:
-          - ruby: '2.7'
-            rails: activerecord_4.2
-          - ruby: '3.0'
-            rails: activerecord_4.2
-          - ruby: '3.0'
-            rails: activerecord_5.0
-          - ruby: '3.0'
-            rails: activerecord_5.1
-          - ruby: '3.0'
-            rails: activerecord_5.2
-          - ruby: '2.5'
-            rails: activerecord_7.0
-          - ruby: '2.6'
-            rails: activerecord_7.0
-          - ruby: '2.5'
-            rails: activerecord_edge
-          - ruby: '2.6'
-            rails: activerecord_edge
+          - 'sqlite3:///:memory:'
+          - mysql2://root:root@0/closure_tree_test
+          - postgres://closure_tree:closure_tree@0/closure_tree_test
 
     steps:
       - name: Checkout
@@ -71,33 +54,15 @@ jobs:
         uses: ruby/setup-ruby@v1
         with:
           ruby-version: ${{ matrix.ruby }}
-
-      - name: Set DB Adapter
-        env:
-          RAILS_VERSION: ${{ matrix.rails }}
-          DB_ADAPTER: ${{ matrix.adapter }}
-
-        # See: https://github.com/actions/virtual-environments/blob/main/images/linux/Ubuntu2004-README.md#mysql
-        run: |
-          if [ "${DB_ADAPTER}" = "mysql2" ]; then
-            sudo systemctl start mysql.service
-            mysql -u root -proot -e 'create database closure_tree;'
-          fi
-
-      - name: Bundle
+          bundler-cache: true
+          rubygems: latest
         env:
-          RAILS_VERSION: ${{ matrix.rails }}
-          DB_ADAPTER: ${{ matrix.adapter }}
           BUNDLE_GEMFILE: gemfiles/${{ matrix.rails }}.gemfile
-        run: |
-          gem install bundler
-          bundle config path vendor/bundle
-          bundle install --jobs 4 --retry 3
 
       - name: RSpec
         env:
           RAILS_VERSION: ${{ matrix.rails }}
           DB_ADAPTER: ${{ matrix.adapter }}
           BUNDLE_GEMFILE: gemfiles/${{ matrix.rails }}.gemfile
           WITH_ADVISORY_LOCK_PREFIX: ${{ github.run_id }}
-        run: bin/rake --trace spec:all
+        run: bin/rake

Appraisals

@@ -1,63 +1,4 @@
-
-appraise 'activerecord-4.2' do
-  gem 'activerecord', '~> 4.2.0'
-  platforms :ruby do
-    gem 'mysql2', "< 0.5"
-    gem 'pg', "~> 0.21"
-    gem 'sqlite3', '~> 1.3.13'
-  end
-
-  platforms :jruby do
-    gem 'activerecord-jdbcmysql-adapter'
-    gem 'activerecord-jdbcpostgresql-adapter'
-    gem 'activerecord-jdbcsqlite3-adapter'
-  end
-end
-
-appraise 'activerecord-5.0' do
-  gem 'activerecord', '~> 5.0.0'
-  platforms :ruby do
-    gem 'mysql2'
-    gem 'pg'
-    gem 'sqlite3', '~> 1.3.13'
-  end
-
-  platforms :jruby do
-    gem 'activerecord-jdbcmysql-adapter'
-    gem 'activerecord-jdbcpostgresql-adapter'
-    gem 'activerecord-jdbcsqlite3-adapter'
-  end
-end
-
-appraise 'activerecord-5.1' do
-  gem 'activerecord', '~> 5.1.0'
-  platforms :ruby do
-    gem 'mysql2'
-    gem 'pg'
-    gem 'sqlite3', '~> 1.3.13'
-  end
-
-  platforms :jruby do
-    gem 'activerecord-jdbcmysql-adapter'
-    gem 'activerecord-jdbcpostgresql-adapter'
-    gem 'activerecord-jdbcsqlite3-adapter'
-  end
-end
-
-appraise 'activerecord-5.2' do
-  gem 'activerecord', '~> 5.2.0'
-  platforms :ruby do
-    gem 'mysql2'
-    gem 'pg'
-    gem 'sqlite3'
-  end
-
-  platforms :jruby do
-    gem 'activerecord-jdbcmysql-adapter'
-    gem 'activerecord-jdbcpostgresql-adapter'
-    gem 'activerecord-jdbcsqlite3-adapter'
-  end
-end
+# frozen_string_literal: true
 
 appraise 'activerecord-6.0' do
   gem 'activerecord', '~> 6.0.0'
@@ -90,7 +31,7 @@ appraise 'activerecord-6.1' do
 end
 
 appraise 'activerecord-7.0' do
-  gem 'activerecord', '~> 7.0.0.alpha2'
+  gem 'activerecord', '~> 7.0.0'
   platforms :ruby do
     gem 'mysql2'
     gem 'pg'

CHANGELOG.md

@@ -1,5 +1,9 @@
 # Changelog
 
+### 8.0.0
+
+- Drop support to EOL ruby and rails
+
 ## [7.4.0](https://github.com/ClosureTree/closure_tree/tree/7.4.0)
 
 [Full Changelog](https://github.com/ClosureTree/closure_tree/compare/v7.3.0...7.4.0)

README.md

@@ -53,7 +53,7 @@ for a description of different tree storage algorithms.
 
 ## Installation
 
-Note that closure_tree only supports ActiveRecord 4.2 and later, and has test coverage for MySQL, PostgreSQL, and SQLite.
+Note that closure_tree only supports ActiveRecord 6.0 and later, and has test coverage for MySQL, PostgreSQL, and SQLite.
 
 1.  Add `gem 'closure_tree'` to your Gemfile
 
@@ -663,8 +663,8 @@ end
 
 Closure tree is [tested under every valid combination](http://travis-ci.org/#!/ClosureTree/closure_tree) of
 
-* Ruby 2.5, 2.6 and 2.7
-* ActiveRecord 4.2, 5.x and 6.0
+* Ruby 2.7+
+* ActiveRecord 6.0+
 * PostgreSQL, MySQL, and SQLite. Concurrency tests are only run with MySQL and PostgreSQL.
 
 Assuming you're using [rbenv](https://github.com/sstephenson/rbenv), you can use ```tests.sh``` to

Rakefile

@@ -35,3 +35,5 @@ GitHubChangelogGenerator::RakeTask.new :changelog do |config|
   config.future_release = '5.2.0'
   config.since_tag = 'v7.4.0'
 end
+
+task :default => "spec:all"

closure_tree.gemspec

@@ -5,9 +5,9 @@ require_relative 'lib/closure_tree/version'
 Gem::Specification.new do |gem|
   gem.name        = 'closure_tree'
   gem.version     = ::ClosureTree::VERSION
-  gem.authors     = ['Matthew McEachen']
-  gem.email       = ['matthew-github@mceachen.org']
-  gem.homepage    = 'http://mceachen.github.io/closure_tree/'
+  gem.authors     = ['Matthew McEachen', 'Abdelkader Boudih']
+  gem.email       = %w[matthew+github@mceachen.org terminale@gmail.com]
+  gem.homepage    = 'https://github.com/ClosureTree/closure_tree/'
 
   gem.summary     = %q(Easily and efficiently make your ActiveRecord model support hierarchies)
   gem.description = gem.summary
@@ -18,9 +18,9 @@ Gem::Specification.new do |gem|
   end
 
   gem.test_files  = gem.files.grep(%r{^spec/})
-  gem.required_ruby_version = '>= 2.0.0'
+  gem.required_ruby_version = '>= 2.6.8'
 
-  gem.add_runtime_dependency 'activerecord', '>= 4.2.10'
+  gem.add_runtime_dependency 'activerecord', '>= 6.0.0'
   gem.add_runtime_dependency 'with_advisory_lock', '>= 4.0.0'
 
   gem.add_development_dependency 'appraisal'