no more tests from hash_tree_scope

Author: mceachen

CHANGELOG.md

@@ -3,6 +3,9 @@
 ### 6.0.0.alpha
 * Drop support for unsupported versions of Rails, 3.2 and 4.0.
 * Drop support for Ruby 1.9 and JRuby 1.9
+* Added support for `.hash_tree` from `.parent` and `.children`. 
+  Addresses [PR146](https://github.com/mceachen/closure_tree/pull/146).
+  Thanks for reporting this and the breaking test, [Mike](https://github.com/mkralla11)!
 
 ### 5.2.0
 

spec/tag_examples.rb

@@ -579,56 +579,9 @@ def assert_parent_and_children
         it 'no limit' do
           expect(tag_class.hash_tree).to eq(@full_tree)
         end
-        # AR Association Tests
-        it 'limit_depth 2 from chained activerecord association subroots' do
-          expect(@a.children.hash_tree(limit_depth: 2)).to eq(@three_tree[@a])
-        end
-        it 'no limit from chained activerecord association subroots' do
-          expect(@a.children.hash_tree).to eq(@full_tree[@a])
-        end
-        it 'limit_depth 3 from b.parent' do
-          expect(@b.parent.hash_tree(limit_depth: 3)).to eq(@three_tree.slice(@a))
-        end
-        it 'no limit_depth from b.parent' do
-          expect(@b.parent.hash_tree).to eq(@full_tree.slice(@a))
-        end
-        it 'no limit_depth from c.parent' do
-          expect(@c1.parent.hash_tree).to eq(@full_tree[@a].slice(@b))
-        end
-      end
-
-      def assert_no_dupes(scope)
-        # the named scope is complicated enough that an incorrect join could result in unnecessarily
-        # duplicated rows:
-        a = scope.collect { |ea| ea.id }
-        expect(a).to eq(a.uniq)
-      end
-
-      context '#hash_tree_scope' do
-        it 'no dupes for any depth' do
-          (0..5).each do |ea|
-            assert_no_dupes(tag_class.hash_tree_scope(ea))
-          end
-        end
-        it 'no limit' do
-          assert_no_dupes(tag_class.hash_tree_scope)
-        end
-      end
-
-      context '.hash_tree_scope' do
-        it 'no dupes for any depth' do
-          (0..5).each do |ea|
-            assert_no_dupes(@a.hash_tree_scope(ea))
-          end
-        end
-        it 'no limit holdum' do
-          assert_no_dupes(@a.hash_tree_scope)
-        end
       end
 
       context '.hash_tree' do
-        before :each do
-        end
         it 'returns {} for depth 0' do
           expect(@b.hash_tree(limit_depth: 0)).to eq({})
         end
@@ -651,6 +604,24 @@ def assert_no_dupes(scope)
           expect(@a.hash_tree.merge(@a2.hash_tree)).to eq(@full_tree)
         end
       end
+
+      context '.hash_tree from relations' do
+        it 'limit_depth 2 from chained activerecord association subroots' do
+          expect(@a.children.hash_tree(limit_depth: 2)).to eq(@three_tree[@a])
+        end
+        it 'no limit from chained activerecord association subroots' do
+          expect(@a.children.hash_tree).to eq(@full_tree[@a])
+        end
+        it 'limit_depth 3 from b.parent' do
+          expect(@b.parent.hash_tree(limit_depth: 3)).to eq(@three_tree.slice(@a))
+        end
+        it 'no limit_depth from b.parent' do
+          expect(@b.parent.hash_tree).to eq(@full_tree.slice(@a))
+        end
+        it 'no limit_depth from c.parent' do
+          expect(@c1.parent.hash_tree).to eq(@full_tree[@a].slice(@b))
+        end
+      end
     end
 
     it 'finds_by_path for very deep trees' do