chore(foundationdb): clippy

Author: PierreZ

foundationdb/examples/class-scheduling.rs

@@ -297,7 +297,7 @@ async fn simulate_students(student_id: usize, num_ops: usize) {
     for _ in 0..num_ops {
         let mut moods = Vec::<Mood>::new();
 
-        if my_classes.len() > 0 {
+        if !my_classes.is_empty() {
             moods.push(Mood::Ditch);
             moods.push(Mood::Switch);
         }
@@ -306,7 +306,7 @@ async fn simulate_students(student_id: usize, num_ops: usize) {
             moods.push(Mood::Add);
         }
 
-        let mood = moods.choose(&mut rng).map(|mood| *mood).unwrap();
+        let mood = moods.choose(&mut rng).copied().unwrap();
 
         // on errors we recheck for available classes
         if perform_op(

foundationdb/src/directory/mod.rs

@@ -148,8 +148,8 @@ impl DirectoryLayer {
     ) -> Result<Subspace, DirectoryError> {
         self.check_version(trx, allow_create).await?;
 
-        if prefix.len() > 0 && !self.allow_manual_prefixes {
-            if self.path.len() == 0 {
+        if !prefix.is_empty() && !self.allow_manual_prefixes {
+            if self.path.is_empty() {
                 return Err(DirectoryError::Message(
                     "cannot specify a prefix unless manual prefixes are enabled".to_string(),
                 ));
@@ -160,7 +160,7 @@ impl DirectoryLayer {
             ));
         }
 
-        if paths.len() == 0 {
+        if paths.is_empty() {
             return Err(DirectoryError::NoPathProvided);
         }
 
@@ -177,7 +177,7 @@ impl DirectoryLayer {
                 return Err(DirectoryError::DirAlreadyExists);
             }
 
-            if self.layer.len() > 0 {
+            if !self.layer.is_empty() {
                 node.check_layer(self.layer.to_owned())?;
             }
 
@@ -282,12 +282,10 @@ impl DirectoryLayer {
 
             node.retrieve_layer(&trx).await?;
 
-            match trx.get(node.node_subspace.bytes(), false).await? {
-                Some(fdb_slice) => {
-                    node.content_subspace = Some(Subspace::from_bytes(&*fdb_slice));
-                }
-                _ => {} // noop in case of a none existing node
+            if let Some(fdb_slice) = trx.get(node.node_subspace.bytes(), false).await? {
+                node.content_subspace = Some(Subspace::from_bytes(&*fdb_slice));
             }
+
             nodes.push(node);
         }
 

foundationdb/src/directory/node.rs

@@ -49,7 +49,7 @@ impl Node {
 
         self.content_subspace = Some(new_subspace.to_owned());
 
-        Ok(new_subspace.clone())
+        Ok(new_subspace)
     }
 
     /// retrieve the layer used for this node

foundationdb/src/tuple/mod.rs

@@ -274,11 +274,11 @@ mod tests {
 
         // versionstamp
         test_serde(
-            Versionstamp::complete(b"\xaa\xbb\xcc\xdd\xee\xff\x00\x01\x02\x03".clone(), 0),
+            Versionstamp::complete(*b"\xaa\xbb\xcc\xdd\xee\xff\x00\x01\x02\x03", 0),
             b"\x33\xaa\xbb\xcc\xdd\xee\xff\x00\x01\x02\x03\x00\x00",
         );
         test_serde(
-            Versionstamp::complete(b"\x01\x02\x03\x04\x05\x06\x07\x08\x09\x0a".clone(), 657),
+            Versionstamp::complete(*b"\x01\x02\x03\x04\x05\x06\x07\x08\x09\x0a", 657),
             b"\x33\x01\x02\x03\x04\x05\x06\x07\x08\x09\x0a\x02\x91",
         );
 
@@ -627,21 +627,21 @@ mod tests {
         test_serde(Element::Int(-1), &[0x13, 254]);
         test_serde(
             Element::Versionstamp(Versionstamp::complete(
-                b"\x01\x02\x03\x04\x05\x06\x07\x08\x09\x0a".clone(),
+                *b"\x01\x02\x03\x04\x05\x06\x07\x08\x09\x0a",
                 657,
             )),
             b"\x33\x01\x02\x03\x04\x05\x06\x07\x08\x09\x0a\x02\x91",
         );
         test_serde(
             (Element::Versionstamp(Versionstamp::complete(
-                b"\x01\x02\x03\x04\x05\x06\x07\x08\x09\x0a".clone(),
+                *b"\x01\x02\x03\x04\x05\x06\x07\x08\x09\x0a",
                 657,
             )),),
             b"\x33\x01\x02\x03\x04\x05\x06\x07\x08\x09\x0a\x02\x91",
         );
         test_serde(
             (Element::Versionstamp(Versionstamp::complete(
-                b"\x01\x02\x03\x04\x05\x06\x07\x08\x09\x0a".clone(),
+                *b"\x01\x02\x03\x04\x05\x06\x07\x08\x09\x0a",
                 657,
             )),),
             b"\x33\x01\x02\x03\x04\x05\x06\x07\x08\x09\x0a\x02\x91",

foundationdb/tests/range.rs

@@ -51,8 +51,8 @@ async fn test_get_range_async() -> FdbResult<()> {
         let len = range.len();
         let mut i = 0;
         for kv in &range {
-            assert!(kv.key().len() > 0);
-            assert!(kv.value().len() > 0);
+            assert!(!kv.key().is_empty());
+            assert!(!kv.value().is_empty());
             i += 1;
         }
         assert_eq!(i, len);

foundationdb/tests/tokio.rs

@@ -22,7 +22,7 @@ async fn do_transact() {
             .expect("failed to open fdb"),
     );
 
-    let adb = db.clone();
+    let adb = db;
     tokio::spawn(async move {
         async fn txnfn(_txn: &Transaction) -> FdbResult<()> {
             Ok(())
@@ -45,7 +45,7 @@ async fn do_trx() {
             .expect("failed to open fdb"),
     );
 
-    let adb = db.clone();
+    let adb = db;
     tokio::spawn(async move {
         adb.create_trx()
             .expect("failed to create trx")

foundationdb/tests/watch.rs

@@ -17,7 +17,7 @@ fn test_watch() {
 }
 
 async fn test_watch_async() -> FdbResult<()> {
-    const KEY: &'static [u8] = b"test-watch";
+    const KEY: &[u8] = b"test-watch";
 
     let db = common::database().await?;
 
@@ -40,7 +40,7 @@ async fn test_watch_async() -> FdbResult<()> {
 }
 
 async fn test_watch_without_commit_async() -> FdbResult<()> {
-    const KEY: &'static [u8] = b"test-watch-2";
+    const KEY: &[u8] = b"test-watch-2";
 
     let db = common::database().await?;