Skip to content

Conversation

@n-oden
Copy link
Contributor

@n-oden n-oden commented Oct 17, 2022

  • add logback jars to all components
  • pin slf4j version to what's bundled w/ logback-classic

zhicwu and others added 3 commits August 29, 2022 23:37
Merge most recent changes on develop branch
Update readme and workflows
- add logback jars to all components
- pin slf4j version to what's bundled w/ logback-classic
@n-oden
Copy link
Contributor Author

n-oden commented Oct 17, 2022

See ClickHouse/clickhouse-jdbc-bridge#159 for backstory. :)

This is my first time working with a multi-component repo like this so if there's a more concise way to do this I'm all ears.

@github-actions
Copy link

Benchmark                                (client)  (connection)  (statement)  (type)   Mode  Cnt     Score     Error  Units
Basic.insertOneRandomNumber  clickhouse-http-jdbc         reuse       normal  object  thrpt   20   275.996 ±  37.918  ops/s
Basic.insertOneRandomNumber  clickhouse-http-jdbc         reuse     prepared  object  thrpt   20   275.621 ±  22.563  ops/s
Basic.insertOneRandomNumber  clickhouse-http-jdbc           new       normal  object  thrpt   20   299.050 ±  29.040  ops/s
Basic.insertOneRandomNumber  clickhouse-http-jdbc           new     prepared  object  thrpt   20   278.159 ±  19.705  ops/s
Basic.insertOneRandomNumber  clickhouse-grpc-jdbc         reuse       normal  object  thrpt   20   311.691 ±  31.782  ops/s
Basic.insertOneRandomNumber  clickhouse-grpc-jdbc         reuse     prepared  object  thrpt   20   270.571 ±  21.867  ops/s
Basic.insertOneRandomNumber  clickhouse-grpc-jdbc           new       normal  object  thrpt   20   310.355 ±  33.482  ops/s
Basic.insertOneRandomNumber  clickhouse-grpc-jdbc           new     prepared  object  thrpt   20   269.994 ±  29.320  ops/s
Basic.selectOneRandomNumber  clickhouse-http-jdbc         reuse       normal  object  thrpt   20  1217.763 ± 118.279  ops/s
Basic.selectOneRandomNumber  clickhouse-http-jdbc         reuse     prepared  object  thrpt   20  1262.711 ± 100.956  ops/s
Basic.selectOneRandomNumber  clickhouse-http-jdbc           new       normal  object  thrpt   20  1243.562 ±  93.680  ops/s
Basic.selectOneRandomNumber  clickhouse-http-jdbc           new     prepared  object  thrpt   20  1286.681 ±  94.029  ops/s
Basic.selectOneRandomNumber  clickhouse-grpc-jdbc         reuse       normal  object  thrpt   20  1120.604 ±  76.453  ops/s
Basic.selectOneRandomNumber  clickhouse-grpc-jdbc         reuse     prepared  object  thrpt   20  1046.453 ± 136.123  ops/s
Basic.selectOneRandomNumber  clickhouse-grpc-jdbc           new       normal  object  thrpt   20  1147.505 ±  86.159  ops/s
Basic.selectOneRandomNumber  clickhouse-grpc-jdbc           new     prepared  object  thrpt   20  1172.857 ±  70.386  ops/s

@n-oden
Copy link
Contributor Author

n-oden commented Oct 26, 2022

I'm pretty sure that the test failure here is unrelated to my code change.

@zhicwu
Copy link
Contributor

zhicwu commented Oct 26, 2022

Sorry for the late response @n-oden and thanks for the pull request. Yes, the build failure is completely irrelevant to the change.

The proposed change looks good but I would not merge. The major concern is that we prefer least dependency, but the change introduced many mandatory dependencies even we know they're optional. Since we support slf4j, I think it's better to leave that to downstream applications to choose, agree?

Having said that, I think it's probably a good idea to add an example for using logback in case it's needed somewhere.

@zhicwu zhicwu changed the base branch from master to develop November 10, 2022 15:35
@zhicwu zhicwu closed this Nov 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants