Refactor HttpAPIClientHelper to improve response cleanup handling

Author: aleksei-griaznov

client-v2/src/main/java/com/clickhouse/client/api/Client.java

@@ -1605,6 +1605,7 @@ public CompletableFuture<QueryResponse> query(String sqlQuery, Map<String, Objec
                         if (httpResponse.getCode() == HttpStatus.SC_SERVICE_UNAVAILABLE) {
                             LOG.warn("Failed to get response. Server returned {}. Retrying. (Duration: {})", System.nanoTime() - startTime, httpResponse.getCode());
                             selectedEndpoint = getNextAliveNode();
+                            HttpAPIClientHelper.closeQuietly(httpResponse);
                             continue;
                         }
 
@@ -1625,7 +1626,7 @@ public CompletableFuture<QueryResponse> query(String sqlQuery, Map<String, Objec
                         return new QueryResponse(httpResponse, responseFormat, requestSettings, metrics);
 
                     } catch (Exception e) {
-                        httpClientHelper.closeQuietly(httpResponse);
+                        HttpAPIClientHelper.closeQuietly(httpResponse);
                         lastException = httpClientHelper.wrapException(String.format("Query request failed (Attempt: %s/%s - Duration: %s)",
                                 (i + 1), (retries + 1), System.nanoTime() - startTime), e);
                         if (httpClientHelper.shouldRetry(e, requestSettings.getAllSettings())) {

client-v2/src/main/java/com/clickhouse/client/api/internal/HttpAPIClientHelper.java

@@ -454,14 +454,9 @@ public ClassicHttpResponse executeRequest(Endpoint server, Map<String, Object> r
             if (httpResponse.getCode() == HttpStatus.SC_PROXY_AUTHENTICATION_REQUIRED) {
                 throw new ClientMisconfigurationException("Proxy authentication required. Please check your proxy settings.");
             } else if (httpResponse.getCode() == HttpStatus.SC_BAD_GATEWAY) {
-                httpResponse.close();
                 throw new ClientException("Server returned '502 Bad gateway'. Check network and proxy settings.");
             } else if (httpResponse.getCode() >= HttpStatus.SC_BAD_REQUEST || httpResponse.containsHeader(ClickHouseHttpProto.HEADER_EXCEPTION_CODE)) {
-                try {
-                    throw readError(httpResponse);
-                } finally {
-                    httpResponse.close();
-                }
+                throw readError(httpResponse);
             }
             return httpResponse;
 
@@ -473,10 +468,13 @@ public ClassicHttpResponse executeRequest(Endpoint server, Map<String, Object> r
             closeQuietly(httpResponse);
             LOG.warn("Failed to connect to '{}': {}", server.getBaseURL(), e.getMessage());
             throw e;
+        } catch (Exception e) {
+            closeQuietly(httpResponse);
+            throw e;
         }
     }
 
-    public void closeQuietly(ClassicHttpResponse httpResponse) {
+    public static void closeQuietly(ClassicHttpResponse httpResponse) {
         if (httpResponse != null) {
             try {
                 httpResponse.close();