Skip to content

Commit e63001d

Browse files
authored
Merge pull request #435 from ClickHouse/install-nullable-columns
Add nothing.h to the list of installed files
2 parents 22dc944 + beb10fc commit e63001d

File tree

3 files changed

+16
-0
lines changed

3 files changed

+16
-0
lines changed

clickhouse/CMakeLists.txt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -221,6 +221,7 @@ INSTALL(FILES columns/ip4.h DESTINATION include/clickhouse/columns/)
221221
INSTALL(FILES columns/ip6.h DESTINATION include/clickhouse/columns/)
222222
INSTALL(FILES columns/itemview.h DESTINATION include/clickhouse/columns/)
223223
INSTALL(FILES columns/lowcardinality.h DESTINATION include/clickhouse/columns/)
224+
INSTALL(FILES columns/nothing.h DESTINATION include/clickhouse/columns/)
224225
INSTALL(FILES columns/nullable.h DESTINATION include/clickhouse/columns/)
225226
INSTALL(FILES columns/numeric.h DESTINATION include/clickhouse/columns/)
226227
INSTALL(FILES columns/map.h DESTINATION include/clickhouse/columns/)

clickhouse/client.h

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@
1111
#include "columns/ip4.h"
1212
#include "columns/ip6.h"
1313
#include "columns/lowcardinality.h"
14+
#include "columns/nothing.h"
1415
#include "columns/nullable.h"
1516
#include "columns/numeric.h"
1617
#include "columns/map.h"

ut/client_ut.cpp

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -434,6 +434,20 @@ TEST_P(ClientCase, Nullable) {
434434
EXPECT_EQ(sizeof(TEST_DATA) / sizeof(TEST_DATA[0]), row);
435435
}
436436

437+
TEST_P(ClientCase, Nothing) {
438+
size_t total_row_count = 0;
439+
client_->Select("SELECT NULL", [&total_row_count](const Block & block)
440+
{
441+
total_row_count += block.GetRowCount();
442+
for (size_t i = 0; i < block.GetRowCount(); ++i) {
443+
EXPECT_TRUE(block[0]->AsStrict<ColumnNullable>()->IsNull(i));
444+
auto column = ColumnNullableT<ColumnNothing>::Wrap(block[0]->AsStrict<ColumnNullable>());
445+
EXPECT_FALSE(column->At(i).has_value());
446+
}
447+
});
448+
ASSERT_EQ(total_row_count, 1UL);
449+
}
450+
437451
TEST_P(ClientCase, Numbers) {
438452
try {
439453
size_t num = 0;

0 commit comments

Comments
 (0)