Skip to content

Commit d0c6abc

Browse files
committed
Some fixes to ItemView pretty-printing
1 parent 5b7a590 commit d0c6abc

File tree

1 file changed

+8
-8
lines changed

1 file changed

+8
-8
lines changed

ut/utils.cpp

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -390,13 +390,13 @@ std::ostream& operator<<(std::ostream& ostr, const ItemView& item_view) {
390390
ostr << DateTimeValue(item_view.get<uint32_t>());
391391
break;
392392
case Type::DateTime64: {
393-
if (item_view.data.size() == 4) {
393+
if (item_view.data.size() == sizeof(int32_t)) {
394394
ostr << DateTimeValue(item_view.get<int32_t>());
395395
}
396-
else if (item_view.data.size() == 8) {
396+
else if (item_view.data.size() == sizeof(int64_t)) {
397397
ostr << DateTimeValue(item_view.get<int64_t>());
398398
}
399-
else if (item_view.data.size() == 16) {
399+
else if (item_view.data.size() == sizeof(Int128)) {
400400
ostr << DateTimeValue(item_view.get<Int128>());
401401
}
402402
else {
@@ -405,10 +405,10 @@ std::ostream& operator<<(std::ostream& ostr, const ItemView& item_view) {
405405
break;
406406
}
407407
case Type::Enum8:
408-
ostr << static_cast<unsigned int>(item_view.get<uint8_t>());
408+
ostr << static_cast<int>(item_view.get<int8_t>());
409409
break;
410410
case Type::Enum16:
411-
ostr << static_cast<unsigned int>(item_view.get<uint16_t>());
411+
ostr << static_cast<int>(item_view.get<int16_t>());
412412
break;
413413
case Type::UUID: {
414414
const auto & uuid_vals = reinterpret_cast<const uint64_t*>(item_view.data.data());
@@ -431,13 +431,13 @@ std::ostream& operator<<(std::ostream& ostr, const ItemView& item_view) {
431431
ostr << item_view.get<UInt128>();
432432
break;
433433
case Type::Decimal: {
434-
if (item_view.data.size() == 4) {
434+
if (item_view.data.size() == sizeof(int32_t)) {
435435
ostr << item_view.get<int32_t>();
436436
}
437-
else if (item_view.data.size() == 8) {
437+
else if (item_view.data.size() == sizeof(int64_t)) {
438438
ostr << item_view.get<int64_t>();
439439
}
440-
else if (item_view.data.size() == 16) {
440+
else if (item_view.data.size() == sizeof(Int128)) {
441441
ostr << item_view.get<Int128>();
442442
}
443443
else {

0 commit comments

Comments
 (0)