Merge pull request #684 from ClickHouse/Proper-skull-and-bones-for-the-combined-metric

alexey-milovidov · web-flow · commit 36ad349e0c05 · 2025-11-07T04:34:44.000+01:00
Proper skull-and-bones for the combined metric
diff --git a/index.html b/index.html
@@ -681,7 +681,7 @@ <h2>Detailed Comparison</h2>
     const hot_timing = (timings[1] !== null && timings[2] !== null ? Math.min(timings[1], timings[2]) : null);
 
     return metric == 'cold' ? cold_timing : metric == 'hot' ? hot_timing :
-        ((hot_timing * combined_hot_share + cold_timing * combined_cold_share) / (combined_hot_share + combined_cold_share));
+        (hot_timing !== null && cold_timing !== null ? (hot_timing * combined_hot_share + cold_timing * combined_cold_share) / (combined_hot_share + combined_cold_share) : null);
 }
 
 function relativeQueryTime(num_queries, baseline_data, elem, metric) {

Original file line number	Diff line number	Diff line change
`@@ -681,7 +681,7 @@ <h2>Detailed Comparison</h2>`
`681`	`681`	`const hot_timing = (timings[1] !== null && timings[2] !== null ? Math.min(timings[1], timings[2]) : null);`
`682`	`682`
`683`	`683`	`return metric == 'cold' ? cold_timing : metric == 'hot' ? hot_timing :`
`684`		`- ((hot_timing * combined_hot_share + cold_timing * combined_cold_share) / (combined_hot_share + combined_cold_share));`
	`684`	`+ (hot_timing !== null && cold_timing !== null ? (hot_timing * combined_hot_share + cold_timing * combined_cold_share) / (combined_hot_share + combined_cold_share) : null);`
`685`	`685`	`}`
`686`	`686`
`687`	`687`	`function relativeQueryTime(num_queries, baseline_data, elem, metric) {`