Add save_cache option #1577
Merged
Add save_cache option #1577
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ph-kev
force-pushed
the
kp/restart
branch
2 times, most recently
from
48ca224 to
dd0b7bf
Compare
Member
|
Should we merge this? |
Member
Author
|
I was hoping for @juliasloan25 to also take a look at it, but I'm okay with merging it in. |
Member
Ah ok, we can wait for Julia. |
juliasloan25
approved these changes
Dec 2, 2025
Member
juliasloan25
left a comment
juliasloan25
left a comment
There was a problem hiding this comment.
Looks good, thank you! Just a couple coments
ph-kev
force-pushed
the
kp/restart
branch
6 times, most recently
from
5b2253d to
6e19df1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1561 - This PR adds
save_cacheas an option to save the cache or not. This is useful withrestart_cache = false.