Skip to content

Rewrite updraft_cloud_diagnostics as a point function #4123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Rewrite updraft_cloud_diagnostics as a point function #4123

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0c2adfa
Rewrite update_cloud_diagnostics as a point function to avoid GPU com…
daverumph Nov 26, 2025
acf2b45
Merge branch 'main' into dr/gpu_perf/cloud_fractions
daverumph Nov 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 18 additions & 17 deletions src/cache/cloud_fraction.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,6 +123,23 @@ NVTX.@annotate function set_cloud_fraction!(
end


function updraft_cloud_diagnostics(ρʲs, ρaʲs, tsʲs, thermo_params, n)
FT = eltype(thermo_params)
cf = FT(0)
q_liq = FT(0)
q_ice = FT(0)
for j in 1:n
aʲ = draft_area(ρaʲs.:($j), ρʲs.:($j))
if TD.has_condensate(thermo_params, tsʲs.:($j))
cf += aʲ
end
(; liq, ice) = TD.PhasePartition(thermo_params, tsʲs.:($j))
q_liq += aʲ * liq
q_ice += aʲ * ice
end
return (; cf, q_liq, q_ice)
end

NVTX.@annotate function set_cloud_fraction!(
Y,
p,
Expand Down Expand Up @@ -159,24 +176,8 @@ NVTX.@annotate function set_cloud_fraction!(
n = n_mass_flux_subdomains(turbconv_model)
if n > 0
(; ᶜρaʲs, ᶜρʲs, ᶜtsʲs) = p.precomputed
@. cloud_diagnostics_tuple += updraft_cloud_diagnostics(ᶜρaʲs, ᶜρʲs, ᶜtsʲs, thermo_params, n)
end

for j in 1:n
@. cloud_diagnostics_tuple += NamedTuple{(:cf, :q_liq, :q_ice)}(
tuple(
ifelse(
TD.has_condensate(thermo_params, ᶜtsʲs.:($$j)),
draft_area(ᶜρaʲs.:($$j), ᶜρʲs.:($$j)),
0,
),
draft_area(ᶜρaʲs.:($$j), ᶜρʲs.:($$j)) *
TD.PhasePartition(thermo_params, ᶜtsʲs.:($$j)).liq,
draft_area(ᶜρaʲs.:($$j), ᶜρʲs.:($$j)) *
TD.PhasePartition(thermo_params, ᶜtsʲs.:($$j)).ice,
),
)
end

end

NVTX.@annotate function set_cloud_fraction!(
Expand Down
Loading