Skip to content

Bug in rain 2M+PEDMF terminal velocity calculation #4117

@haakon-e

Description

@haakon-e

In the updrafts, we pass ᶜρʲ * ᶜn_raiʲ to CM2.rain_terminal_velocity, see e.g.:

@. ᶜwᵣʲs.:($$j) = getindex(
CM2.rain_terminal_velocity(
cm2p.sb,
cm2p.rtv,
max(zero(Y.c.ρ), Y.c.sgsʲs.:($$j).q_rai),
ᶜρʲs.:($$j),
max(zero(Y.c.ρ), ᶜρʲs.:($$j) * Y.c.sgsʲs.:($$j).n_rai),
),
2,
)

while in the environment, we only pass ᶜn_rai⁰ to CM2.rain_terminal_velocity, see e.g.:

# Rain (mass)
@. ᶜw⁰ = getindex(
CM2.rain_terminal_velocity(
cm2p.sb,
cm2p.rtv,
max(zero(Y.c.ρ), ᶜq_rai⁰),
ᶜρ⁰,
max(zero(Y.c.ρ), ᶜn_rai⁰),
),
2,
)

This applies to all condensate species.

The correct approach is to pass ρ * n

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions