add diffusivity diagnostics

Author: haakon-e

src/cache/precomputed_quantities.jl

@@ -248,11 +248,12 @@ function precomputed_quantities(Y, atmos)
     smagorinsky_quantities =
         if atmos.smagorinsky_horizontal isa SmagorinskyLilly ||
            atmos.smagorinsky_vertical isa SmagorinskyLilly
-           uvw_vec = UVW(FT(0), FT(0), FT(0))
+            uvw_vec = UVW(FT(0), FT(0), FT(0))
             (;
                 ᶜS = similar(Y.c, typeof(uvw_vec * uvw_vec')),
                 ᶠS = similar(Y.f, typeof(uvw_vec * uvw_vec')),
                 ᶜL_h = similar(Y.c, FT), ᶜL_v = similar(Y.c, FT),
+                ᶜD_h = similar(Y.c, FT), ᶠD_v = similar(Y.f, FT),
             )
         else
             (;)

src/diagnostics/core_diagnostics.jl

@@ -343,6 +343,26 @@ add_diagnostic_variable!(
     end,
 )
 
+###
+# Smagorinski Lilly diffusivity
+###
+add_diagnostic_variable!(
+    short_name = "D_smag_h",
+    long_name = "Horizontal smagorinski diffusivity",
+    units = "m^2 s^-1",
+    compute! = (out, _, cache, _) -> begin
+        isnothing(out) ? copy(cache.precomputed.ᶜD_h) : (out .= cache.precomputed.ᶜD_h)
+    end,
+)
+add_diagnostic_variable!(
+    short_name = "D_smag_v",
+    long_name = "Horizontal smagorinski diffusivity",
+    units = "m^2 s^-1",
+    compute! = (out, _, cache, _) -> begin
+        isnothing(out) ? copy(cache.precomputed.ᶠD_v) : (out .= cache.precomputed.ᶠD_v)
+    end,
+)
+
 ###
 # Relative humidity (3d)
 ###

src/parameterized_tendencies/les_sgs_models/smagorinsky_lilly.jl

@@ -77,6 +77,7 @@ function horizontal_smagorinsky_lilly_tendency!(Yₜ, Y, p, t, ::SmagorinskyLill
 
     # Turbulent diffusivity
     ᶜD_smag = @. ᶜtemp_scalar = ᶜνₜ_h / Pr_t
+    @. p.precomputed.ᶜD_h = ᶜD_smag  # save to diagnostics
 
     # Subgrid-scale momentum flux tensor, `τ = -2 νₜ ∘ S`
     ᶜτ_smag = @. ᶜtemp_UVWxUVW = -2 * ᶜνₜ_h * ᶜS  # TODO: Lazify once we can mix lazy horizontal & vertical operations
@@ -140,6 +141,7 @@ function vertical_smagorinsky_lilly_tendency!(Yₜ, Y, p, t, ::SmagorinskyLilly)
 
     # Turbulent diffusivity
     ᶠD_smag = @. ᶠtemp_scalar_2 = ᶠνₜ_v / Pr_t
+    @. p.precomputed.ᶠD_v = ᶠD_smag  # save to diagnostics
 
     # Apply to tendencies
     ## Horizontal momentum tendency