rft: split horizontal and vertical smagorinsky

- add diffusivity diagnostics
- implicit vertical smagorinsky
- les ci_plots edits
- use vertical strain for lilly correction
- full strain rate method

Author: haakon-e

config/default_configs/default_config.yml

@@ -170,7 +170,7 @@ c_amd:
   help: "Model coefficient for AMD-LES closure (TODO: Move to parameters.toml)"
   value: 0.29
 smagorinsky_lilly:
-  help: "Smagorinsky-Lilly diffusive closure [`nothing` (default), `UVW`]"
+  help: "Smagorinsky-Lilly diffusive closure [`nothing` (default), `UVW`, `UV`, `W`, `UV_W_decoupled`]"
   value: ~
 bubble:
   help: "Enable bubble correction for more accurate surface areas"

src/parameterized_tendencies/les_sgs_models/smagorinsky_lilly.jl

@@ -73,6 +73,9 @@ function set_smagorinsky_lilly_precomputed_quantities!(Y, p, model)
     ᶜfb = lilly_stratification_correction(p, ᶜS)
     if is_smagorinsky_UVW_coupled(model)
         @. ᶜL_h = ᶜL_v = c_smag * cbrt(ᶜΔ_z * Δ_h^2) * ᶜfb
+    else
+        @. ᶜL_h = c_smag * Δ_h
+        @. ᶜL_v = c_smag * ᶜΔ_z * ᶜfb
     end
 
     ᶜS_norm_h .= strain_rate_norm(ᶜS, ax_h)

src/solver/model_getters.jl

@@ -176,12 +176,15 @@ Get the Smagorinsky-Lilly turbulence model based on `parsed_args["smagorinsky_li
 
 The possible model configurations flags are:
 - `UVW`: Applies the model to all spatial directions.
+- `UV`: Applies the model to the horizontal direction only.
+- `W`: Applies the model to the vertical direction only.
+- `UV_W`: Applies the model to the horizontal and vertical directions separately.
 """
 function get_smagorinsky_lilly_model(parsed_args)
     smag = parsed_args["smagorinsky_lilly"]
     isnothing(smag) && return nothing
     smag_symbol = Symbol(smag)
-    @assert smag_symbol in (:UVW,)
+    @assert smag_symbol in (:UVW, :UV, :W, :UV_W)
     return SmagorinskyLilly{smag_symbol}()
 end
 

src/solver/types.jl

@@ -246,6 +246,9 @@ Smagorinsky-Lilly eddy viscosity model.
 
 `DIR` is a symbol indicating in which direction(s) the model is applied. It can be
 - `:UVW` (all directions)
+- `:UV` (horizontal only)
+- `:W` (vertical only), or
+- `:UV_W` (horizontal and vertical treated separately).
 """
 struct SmagorinskyLilly{DIR} <: AbstractEddyViscosityModel end
 
@@ -265,7 +268,7 @@ Check if the Smagorinsky model is applied in the vertical direction.
 See also [`is_smagorinsky_horizontal`](@ref).
 """
 is_smagorinsky_vertical(::SmagorinskyLilly{DIR}) where {DIR} =
-    DIR == :UVW
+    DIR == :UVW || DIR == :W || DIR == :UV_W
 is_smagorinsky_vertical(::Nothing) = false
 
 """
@@ -276,7 +279,7 @@ Check if the Smagorinsky model is applied in the horizontal directions.
 See also [`is_smagorinsky_vertical`](@ref).
 """
 is_smagorinsky_horizontal(::SmagorinskyLilly{DIR}) where {DIR} =
-    DIR == :UVW
+    DIR == :UVW || DIR == :UV || DIR == :UV_W
 is_smagorinsky_horizontal(::Nothing) = false
 
 struct AnisotropicMinimumDissipation{FT} <: AbstractEddyViscosityModel