fix vertical_transport with vanleer_limiter on GPU

nefrathenrici · nefrathenrici · commit 9d10698e52fc · 2025-12-01T11:58:34.000-08:00
diff --git a/.buildkite/pipeline.yml b/.buildkite/pipeline.yml
@@ -1281,7 +1281,7 @@ steps:
           CLIMACOMMS_DEVICE: "CUDA"
           CLIMA_NAME_CUDA_KERNELS_FROM_STACK_TRACE: "true"
         agents:
-          slurm_mem: 24GB
+          slurm_mem: 32GB
           slurm_gpus: 1
 
   - group: "Flame graphs"
diff --git a/config/model_configs/diagnostic_edmfx_aquaplanet_gpu.yml b/config/model_configs/diagnostic_edmfx_aquaplanet_gpu.yml
@@ -9,6 +9,8 @@ edmfx_detr_model: "Generalized"
 edmfx_nh_pressure: true
 edmfx_sgs_mass_flux: true
 edmfx_sgs_diffusive_flux: true
+edmfx_sgsflux_upwinding: "vanleer_limiter"
+edmfx_tracer_upwinding: "vanleer_limiter"
 moist: equil
 cloud_model: "quadrature_sgs"
 precip_model: 0M
diff --git a/src/prognostic_equations/implicit/implicit_tendency.jl b/src/prognostic_equations/implicit/implicit_tendency.jl
@@ -86,6 +86,8 @@ end
     function vertical_transport(ᶜρ, ᶠu³, ᶜχ, dt, ::Val{:vanleer_limiter})
         ᶜJ = Fields.local_geometry_field(axes(ᶜρ)).J
         ᶠJ = Fields.local_geometry_field(axes(ᶠu³)).J
+        FT = eltype(ᶠJ)
+        dt = FT(dt)
         return @. lazy(
             -(ᶜadvdivᵥ(ᶠinterp(ᶜρ * ᶜJ) / ᶠJ * ᶠlin_vanleer(ᶠu³, ᶜχ, dt))),
         )

Original file line number	Diff line number	Diff line change
`@@ -86,6 +86,8 @@ end`
`86`	`86`	`function vertical_transport(ᶜρ, ᶠu³, ᶜχ, dt, ::Val{:vanleer_limiter})`
`87`	`87`	`ᶜJ = Fields.local_geometry_field(axes(ᶜρ)).J`
`88`	`88`	`ᶠJ = Fields.local_geometry_field(axes(ᶠu³)).J`
	`89`	`+ FT = eltype(ᶠJ)`
	`90`	`+ dt = FT(dt)`
`89`	`91`	`return @. lazy(`
`90`	`92`	`-(ᶜadvdivᵥ(ᶠinterp(ᶜρ * ᶜJ) / ᶠJ * ᶠlin_vanleer(ᶠu³, ᶜχ, dt))),`
`91`	`93`	`)`