Skip to content

Conversation

@akinross
Copy link
Collaborator

No description provided.

@akinross akinross added the jira-sync Sync this issue to Jira label Nov 25, 2025
@akinross akinross force-pushed the bug_version_check_children branch from dc6fb13 to a410de7 Compare November 25, 2025 20:20
shrsr
shrsr previously approved these changes Nov 26, 2025
Copy link
Collaborator

@shrsr shrsr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shrsr shrsr added jira-sync Sync this issue to Jira and removed jira-sync Sync this issue to Jira labels Nov 26, 2025
@github-actions github-actions bot changed the title [bugfix] fix child classes to be queried only when apic versions allows [bugfix] fix child classes to be queried only when apic versions allows (DCNE-589) Nov 26, 2025
resource.TestCheckResourceAttrSet("aci_{{$.resourceName}}.test", "{{$key}}"),
{{- end}}
{{- range $key, $value := $.children}}
// foo
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// foo

gmicol
gmicol previously approved these changes Dec 2, 2025
Copy link
Collaborator

@gmicol gmicol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

gmicol
gmicol previously approved these changes Dec 2, 2025
Copy link
Collaborator

@gmicol gmicol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

samiib
samiib previously approved these changes Dec 2, 2025
Copy link
Collaborator

@samiib samiib left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

shrsr
shrsr previously approved these changes Dec 2, 2025
Copy link
Collaborator

@shrsr shrsr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@akinross akinross dismissed stale reviews from shrsr, samiib, and gmicol via 43b7294 December 3, 2025 06:56
@akinross akinross requested a review from shrsr December 3, 2025 06:57
@akinross akinross requested review from gmicol and samiib December 3, 2025 06:57
shrsr
shrsr previously approved these changes Dec 3, 2025
Copy link
Collaborator

@shrsr shrsr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

samiib
samiib previously approved these changes Dec 3, 2025
Copy link
Collaborator

@samiib samiib left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@akinross akinross dismissed stale reviews from samiib and shrsr via cd1c8d8 December 3, 2025 07:42
@akinross akinross force-pushed the bug_version_check_children branch from 43b7294 to cd1c8d8 Compare December 3, 2025 07:42
Copy link
Collaborator

@sajagana sajagana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@shrsr shrsr requested review from samiib and shrsr December 3, 2025 20:08
Copy link
Collaborator

@shrsr shrsr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@samiib samiib left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@gmicol gmicol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

jira-sync Sync this issue to Jira

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants