fix(wait_for): respect the provided timeout (#630)

The issue is that locator don't modify themselves but create a new
locator.

Closes #624

Author: Lightning00Blade

src/McpContext.ts

@@ -617,25 +617,19 @@ export class McpContext implements Context {
     return this.#networkCollector.getIdForResource(request);
   }
 
-  waitForTextOnPage({
-    text,
-    timeout,
-  }: {
-    text: string;
-    timeout?: number | undefined;
-  }): Promise<Element> {
+  waitForTextOnPage(text: string, timeout?: number): Promise<Element> {
     const page = this.getSelectedPage();
     const frames = page.frames();
 
-    const locator = this.#locatorClass.race(
+    let locator = this.#locatorClass.race(
       frames.flatMap(frame => [
         frame.locator(`aria/${text}`),
         frame.locator(`text/${text}`),
       ]),
     );
 
     if (timeout) {
-      locator.setTimeout(timeout);
+      locator = locator.setTimeout(timeout);
     }
 
     return locator.wait();

src/tools/ToolDefinition.ts

@@ -107,10 +107,7 @@ export type Context = Readonly<{
     filename: string,
   ): Promise<{filename: string}>;
   waitForEventsAfterAction(action: () => Promise<unknown>): Promise<void>;
-  waitForTextOnPage(params: {
-    text: string;
-    timeout?: number | undefined;
-  }): Promise<Element>;
+  waitForTextOnPage(text: string, timeout?: number): Promise<Element>;
   getDevToolsData(): Promise<DevToolsData>;
   /**
    * Returns a reqid for a cdpRequestId.

src/tools/snapshot.ts

@@ -53,7 +53,10 @@ export const waitFor = defineTool({
     ...timeoutSchema,
   },
   handler: async (request, response, context) => {
-    await context.waitForTextOnPage(request.params);
+    await context.waitForTextOnPage(
+      request.params.text,
+      request.params.timeout,
+    );
 
     response.appendResponseLine(
       `Element with text "${request.params.text}" found.`,