Updated code to remove redundant 'ToString' calls (#8348)

Author: glen-84

.editorconfig

@@ -193,6 +193,8 @@ dotnet_style_prefer_collection_expression = when_types_exactly_match
 # Remove unnecessary blank line.
 dotnet_diagnostic.RCS0063.severity = warning
 dotnet_diagnostic.RCS1036.severity = none # see https://github.com/dotnet/roslynator/issues/1632
+# Remove redundant 'ToString' call.
+dotnet_diagnostic.RCS1097.severity = warning
 # Unnecessary null-forgiving operator.
 dotnet_diagnostic.RCS1249.severity = warning
 # Remove unnecessary braces.

src/HotChocolate/Core/src/Types/SchemaPrinter.cs

@@ -93,7 +93,7 @@ public static DocumentNode PrintSchema(
         var directiveTypeDefinitions =
             schema.DirectiveTypes
                 .Where(directive => !builtInDirectives.Contains(directive.Name))
-                .OrderBy(t => t.Name.ToString(), StringComparer.Ordinal)
+                .OrderBy(t => t.Name, StringComparer.Ordinal)
                 .Select(PrintDirectiveTypeDefinition);
 
         typeDefinitions.AddRange(directiveTypeDefinitions);
@@ -102,7 +102,7 @@ public static DocumentNode PrintSchema(
             schema.Types
             .OfType<ScalarType>()
             .Where(t => includeSpecScalars || !BuiltInTypes.IsBuiltInType(t.Name))
-            .OrderBy(t => t.Name.ToString(), StringComparer.Ordinal)
+            .OrderBy(t => t.Name, StringComparer.Ordinal)
             .Select(PrintScalarType);
 
         typeDefinitions.AddRange(scalarTypeDefinitions);
@@ -115,7 +115,7 @@ private static IEnumerable<ITypeDefinition> GetNonScalarTypes(
     {
         return schema.Types
            .Where(IsPublicAndNoScalar)
-           .OrderBy(t => t.Name.ToString(), StringComparer.Ordinal)
+           .OrderBy(t => t.Name, StringComparer.Ordinal)
            .GroupBy(t => (int)t.Kind)
            .OrderBy(t => t.Key)
            .SelectMany(t => t);

src/HotChocolate/Core/test/Types.Tests/Configuration/TypeInitializerTests.cs

@@ -38,7 +38,7 @@ public void Register_SchemaType_ClrTypeExists()
         Assert.True(exists);
         var fooType =
             Assert.IsType<FooType>(type.Type).Fields.ToDictionary(
-                t => t.Name.ToString(),
+                t => t.Name,
                 t => t.Type.Print());
 
         exists = typeRegistry.TryGetType(
@@ -48,7 +48,7 @@ public void Register_SchemaType_ClrTypeExists()
         Assert.True(exists);
         var barType =
             Assert.IsType<BarType>(type.Type).Fields.ToDictionary(
-                t => t.Name.ToString(),
+                t => t.Name,
                 t => t.Type.Print());
 
         new { fooType, barType }.MatchSnapshot();
@@ -93,7 +93,7 @@ public void Register_ClrType_InferSchemaTypes()
         Assert.True(exists);
         var fooType =
             Assert.IsType<ObjectType<Foo>>(type.Type).Fields.ToDictionary(
-                t => t.Name.ToString(),
+                t => t.Name,
                 t => t.Type.Print());
 
         exists = typeRegistry.TryGetType(
@@ -103,7 +103,7 @@ public void Register_ClrType_InferSchemaTypes()
         Assert.True(exists);
         var barType =
             Assert.IsType<ObjectType<Bar>>(type.Type).Fields.ToDictionary(
-                t => t.Name.ToString(),
+                t => t.Name,
                 t => t.Type.Print());
 
         new { fooType, barType }.MatchSnapshot();