Updated code to prefer concrete values over default (#8345)

Author: glen-84

.editorconfig

@@ -124,6 +124,7 @@ resharper_enforce_if_statement_braces_highlighting = error
 resharper_enforce_lock_statement_braces_highlighting = error
 resharper_enforce_using_statement_braces_highlighting = error
 resharper_enforce_while_statement_braces_highlighting = error
+resharper_prefer_concrete_value_over_default_highlighting = error
 
 # ReSharper properties
 resharper_align_multiline_binary_expressions_chain = false

src/CookieCrumble/src/CookieCrumble.Xunit/Attributes/UseCultureAttribute.cs

@@ -18,8 +18,8 @@ public class UseCultureAttribute : BeforeAfterTestAttribute
 {
     private readonly Lazy<CultureInfo> _culture;
     private readonly Lazy<CultureInfo> _uiCulture;
-private CultureInfo _originalCulture = default!;
-    private CultureInfo _originalUiCulture = default!;
+private CultureInfo _originalCulture = null!;
+    private CultureInfo _originalUiCulture = null!;
 
     /// <summary>
     /// Replaces the culture and UI culture of the current thread with

src/GreenDonut/src/GreenDonut.Data.EntityFramework/Expressions/ExpressionHelpers.cs

@@ -353,7 +353,7 @@ public class Group<TKey, TValue>
     {
         public TKey Key { get; set; } = default!;
 
-        public List<TValue> Items { get; set; } = default!;
+        public List<TValue> Items { get; set; } = null!;
     }
 
     public readonly struct OrderRewriterResult(

src/GreenDonut/src/GreenDonut/Result.cs

@@ -13,7 +13,7 @@ public readonly record struct Result<TValue>
     /// <param name="value">The value.</param>
     public Result(TValue value) : this()
     {
-        Error = default;
+        Error = null;
         Value = value;
         Kind = ResultKind.Value;
     }

src/GreenDonut/test/GreenDonut.Data.EntityFramework.Tests/TestContext/Brand.cs

@@ -9,23 +9,23 @@ public class Brand
     public int Id { get; set; }
 
     [Required]
-    public string Name { get; set; } = default!;
+    public string Name { get; set; } = null!;
 
     public string? DisplayName { get; set; }
 
     public string? AlwaysNull { get; set; }
 
     public ICollection<Product> Products { get; set; } = [];
 
-    public BrandDetails BrandDetails { get; set; } = default!;
+    public BrandDetails BrandDetails { get; set; } = null!;
 }
 
 public class BrandDetails
 {
-    public Country Country { get; set; } = default!;
+    public Country Country { get; set; } = null!;
 }
 
 public class Country
 {
-    public string Name { get; set; } = default!;
+    public string Name { get; set; } = null!;
 }

src/GreenDonut/test/GreenDonut.Data.EntityFramework.Tests/TestContext/CatalogContext.cs

@@ -10,13 +10,13 @@ protected override void OnConfiguring(DbContextOptionsBuilder optionsBuilder)
         optionsBuilder.UseNpgsql(connectionString);
     }
 
-    public DbSet<Product> Products { get; set; } = default!;
+    public DbSet<Product> Products { get; set; } = null!;
 
-    public DbSet<ProductType> ProductTypes { get; set; } = default!;
+    public DbSet<ProductType> ProductTypes { get; set; } = null!;
 
-    public DbSet<Brand> Brands { get; set; } = default!;
+    public DbSet<Brand> Brands { get; set; } = null!;
 
-    public DbSet<Test> Tests { get; set; } = default!;
+    public DbSet<Test> Tests { get; set; } = null!;
 
     protected override void OnModelCreating(ModelBuilder builder)
     {

src/GreenDonut/test/GreenDonut.Data.EntityFramework.Tests/TestContext/FooBarContext.cs

@@ -36,7 +36,7 @@ public class Foo
     public int Id { get; set; }
 
     [MaxLength(100)]
-    public string Name { get; set; } = default!;
+    public string Name { get; set; } = null!;
 
     public int? BarId { get; set; }
 
@@ -51,7 +51,7 @@ public class Bar
     public string? Description { get; set; }
 
     [MaxLength(100)]
-    public string SomeField1 { get; set; } = default!;
+    public string SomeField1 { get; set; } = null!;
 
     [MaxLength(100)]
     public string? SomeField2 { get; set; }

src/GreenDonut/test/GreenDonut.Data.EntityFramework.Tests/TestContext/Product.cs

@@ -9,7 +9,7 @@ public class Product
     public int Id { get; set; }
 
     [Required]
-    public string Name { get; set; } = default!;
+    public string Name { get; set; } = null!;
 
     public string? Description { get; set; }
 

src/GreenDonut/test/GreenDonut.Data.EntityFramework.Tests/TestContext/ProductType.cs

@@ -8,7 +8,7 @@ public class ProductType
 {
     public int Id { get; set; }
 
-    [Required] public string Name { get; set; } = default!;
+    [Required] public string Name { get; set; } = null!;
 
     public ICollection<Product> Products { get; } = [];
 }

src/GreenDonut/test/GreenDonut.Data.Tests/Cursors/CursorFormatterTests.cs

@@ -115,7 +115,7 @@ public void Format_And_Parse_Two_Keys_With_Colon()
 
     public class MyClass
     {
-        public string Name { get; set; } = default!;
+        public string Name { get; set; } = null!;
 
         public string? Description { get; set; }
     }