Add option to disable null-bubbling

Author: tobias-tengler

src/HotChocolate/Core/src/Abstractions/WellKnownContextData.cs

@@ -274,17 +274,22 @@ public static class WellKnownContextData
     /// The key to access the authorization allowed flag on the member context.
     /// </summary>
     public const string AllowAnonymous = "HotChocolate.Authorization.AllowAnonymous";
-    
+
     /// <summary>
     /// The key to access the true nullability flag on the execution context.
     /// </summary>
     public const string EnableTrueNullability = "HotChocolate.Types.EnableTrueNullability";
-    
+
+    /// <summary>
+    /// The key to access the disable null-bubbling flag on the execution context.
+    /// </summary>
+    public const string DisableNullBubbling = "HotChocolate.Types.DisableNullBubbling";
+
     /// <summary>
     /// The key to access the tag options object.
     /// </summary>
     public const string TagOptions = "HotChocolate.Types.TagOptions";
-    
+
     /// <summary>
     /// Type key to access the internal schema options.
     /// </summary>

src/HotChocolate/Core/src/Execution/Pipeline/OperationResolverMiddleware.cs

@@ -109,6 +109,11 @@ private IOperation CompileOperation(
 
     private bool IsNullBubblingEnabled(IRequestContext context, OperationDefinitionNode operationDefinition)
     {
+        if (context.Schema.ContextData.ContainsKey(DisableNullBubbling))
+        {
+            return false;
+        }
+
         if (!context.Schema.ContextData.ContainsKey(EnableTrueNullability) ||
             operationDefinition.Directives.Count == 0)
         {

src/HotChocolate/Core/src/Types/IReadOnlySchemaOptions.cs

@@ -55,7 +55,7 @@ public interface IReadOnlySchemaOptions
     /// unreachable from the root types.
     /// </summary>
     bool RemoveUnreachableTypes { get; }
-    
+
     /// <summary>
     /// Defines if unused type system directives shall
     /// be removed from the schema.
@@ -97,7 +97,7 @@ public interface IReadOnlySchemaOptions
     /// Defines if the order of important middleware components shall be validated.
     /// </summary>
     bool ValidatePipelineOrder { get; }
-    
+
     /// <summary>
     /// Defines if the runtime types of types shall be validated.
     /// </summary>
@@ -181,6 +181,11 @@ public interface IReadOnlySchemaOptions
     /// </summary>
     bool EnableTrueNullability { get; }
 
+    /// <summary>
+    /// Specifies whether null-bubbling shall be disabled.
+    /// </summary>
+    bool DisableNullBubbling { get; }
+
     /// <summary>
     /// Specifies that the @tag directive shall be registered with the type system.
     /// </summary>

src/HotChocolate/Core/src/Types/SchemaBuilder.cs

@@ -39,6 +39,7 @@ public partial class SchemaBuilder : ISchemaBuilder
         typeof(CostTypeInterceptor),
         typeof(MiddlewareValidationTypeInterceptor),
         typeof(EnableTrueNullabilityTypeInterceptor),
+        typeof(DisableNullBubblingTypeInterceptor),
     ];
 
     private SchemaOptions _options = new();
@@ -263,7 +264,7 @@ public ISchemaBuilder AddType(INamedTypeExtension typeExtension)
         _types.Add(_ => TypeReference.Create(typeExtension));
         return this;
     }
-    
+
     internal void AddTypeReference(TypeReference typeReference)
     {
         if (typeReference is null)

src/HotChocolate/Core/src/Types/SchemaOptions.cs

@@ -211,6 +211,11 @@ public FieldBindingFlags DefaultFieldBindingFlags
     /// </summary>
     public bool EnableTrueNullability { get; set; }
 
+    /// <summary>
+    /// Specifies whether null-bubbling shall be disabled.
+    /// </summary>
+    public bool DisableNullBubbling { get; set; }
+
     /// <summary>
     /// Specifies that the @tag directive shall be registered with the type system.
     /// </summary>
@@ -263,6 +268,7 @@ public static SchemaOptions FromOptions(IReadOnlySchemaOptions options)
             MaxAllowedNodeBatchSize = options.MaxAllowedNodeBatchSize,
             StripLeadingIFromInterface = options.StripLeadingIFromInterface,
             EnableTrueNullability = options.EnableTrueNullability,
+            DisableNullBubbling = options.DisableNullBubbling,
             EnableTag = options.EnableTag,
             DefaultQueryDependencyInjectionScope = options.DefaultQueryDependencyInjectionScope,
             DefaultMutationDependencyInjectionScope = options.DefaultMutationDependencyInjectionScope,

src/HotChocolate/Core/src/Types/Types/Interceptors/DisableNullBubblingTypeInterceptor.cs

@@ -0,0 +1,20 @@
+#nullable enable
+using HotChocolate.Configuration;
+using HotChocolate.Types.Descriptors;
+using HotChocolate.Types.Descriptors.Definitions;
+
+namespace HotChocolate.Types.Interceptors;
+
+internal sealed class DisableNullBubblingTypeInterceptor : TypeInterceptor
+{
+    internal override bool IsEnabled(IDescriptorContext context)
+        => context.Options.DisableNullBubbling;
+
+    public override void OnAfterInitialize(ITypeDiscoveryContext discoveryContext, DefinitionBase definition)
+    {
+        if (definition is SchemaTypeDefinition schemaDef)
+        {
+            schemaDef.ContextData[WellKnownContextData.DisableNullBubbling] = true;
+        }
+    }
+}