Skip to content

VWAN | Added maintenance mode support #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 22, 2025
Merged

VWAN | Added maintenance mode support #22

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions modules/high_availability_existing_vnet/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@ module "example_module" {
backend_subnet_name = "backend"
frontend_IP_addresses = [5, 6, 7]
backend_IP_addresses = [5, 6, 7]
vips_names = []
admin_password = "xxxxxxxxxxxx"
smart_1_cloud_token_a = "xxxxxxxxxxxx"
smart_1_cloud_token_b = "xxxxxxxxxxxx"
Expand Down Expand Up @@ -121,6 +122,7 @@ module "example_module" {
| **use_public_ip_prefix** | Indicates whether the public IP resources will be deployed with public IP prefix | boolean | true;<br />false;<br />**Default:** false |
| **create_public_ip_prefix** | Indicates whether the public IP prefix will be created or an existing one will be used | boolean | true;<br />false;<br />**Default:** false |
| **existing_public_ip_prefix_id** | The existing public IP prefix resource ID | string | Existing public IP prefix resource ID<br /> |
| **vips_names** | Names for additional Virtual IP addresses beyond the primary cluster VIP. Each name creates a corresponding public IP resource. | list(string) | **Default:** [] |
| **admin_shell** | Enables selecting different admin shells | string | /etc/cli.sh;<br />/bin/bash;<br />/bin/csh;<br />/bin/tcsh;<br /> |
| **serial_console_password_hash** | Optional parameter, used to enable serial console connection in case of SSH key as authentication type | string | |
| **maintenance_mode_password_hash** | Maintenance mode password hash, relevant only for R81.20 and higher versions | string | |
Expand Down
31 changes: 29 additions & 2 deletions modules/high_availability_existing_vnet/main.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ resource "azurerm_public_ip_prefix" "public_ip_prefix" {
name = "${module.common.resource_group_name}-ipprefix"
location = module.common.resource_group_location
resource_group_name = module.common.resource_group_name
prefix_length = 30
prefix_length = length(var.vips_names) > 4 ? 28 : length(var.vips_names) > 0 ? 29 : 30
tags = merge(lookup(var.tags, "public-ip-prefix", {}), lookup(var.tags, "all", {}))
}

Expand Down Expand Up @@ -74,10 +74,24 @@ resource "azurerm_public_ip" "cluster-vip" {
tags = merge(lookup(var.tags, "public-ip", {}), lookup(var.tags, "all", {}))
}

resource "azurerm_public_ip" "vips" {
count = length(var.vips_names)
name = var.vips_names[count.index]
location = module.common.resource_group_location
resource_group_name = module.common.resource_group_name
allocation_method = var.vnet_allocation_method
sku = var.sku
domain_name_label = "${lower(var.vips_names[count.index])}-${count.index}-vip-${random_id.random_id.hex}"
public_ip_prefix_id = var.use_public_ip_prefix ? (var.create_public_ip_prefix ? azurerm_public_ip_prefix.public_ip_prefix[0].id : var.existing_public_ip_prefix_id) : null
tags = merge(lookup(var.tags, "public-ip", {}), lookup(var.tags, "all", {}))
}

resource "azurerm_network_interface" "nic_vip" {
depends_on = [
azurerm_public_ip.cluster-vip,
azurerm_public_ip.public-ip]
azurerm_public_ip.public-ip,
azurerm_public_ip.vips,
]
name = "${var.cluster_name}1-eth0"
location = module.common.resource_group_location
resource_group_name = module.common.resource_group_name
Expand All @@ -100,6 +114,19 @@ resource "azurerm_network_interface" "nic_vip" {
private_ip_address = cidrhost(data.azurerm_subnet.frontend.address_prefixes[0], var.frontend_IP_addresses[2])
public_ip_address_id = azurerm_public_ip.cluster-vip.id
}

dynamic "ip_configuration" {
for_each = var.vips_names
content {
name = "cluster-vip-${index(var.vips_names, ip_configuration.value) + 1}"
subnet_id = data.azurerm_subnet.frontend.id
primary = false
private_ip_address_allocation = var.vnet_allocation_method
private_ip_address = cidrhost(data.azurerm_subnet.frontend.address_prefixes[0], 7 + index(var.vips_names, ip_configuration.value) + 1)
public_ip_address_id = azurerm_public_ip.vips[index(var.vips_names, ip_configuration.value)].id
}
}

lifecycle {
ignore_changes = [
# Ignore changes to ip_configuration when Re-applying, e.g. because a cluster failover and associating the cluster- vip with the other member.
Expand Down
12 changes: 12 additions & 0 deletions modules/high_availability_existing_vnet/variables.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -326,4 +326,16 @@ variable "tags" {
description = "Assign tags by resource."
type = map(map(string))
default = {}
}

variable "vips_names" {
description = "Names to be used for the VIPs"
type = list(string)
default = []

# More than 10 VIPs may result in not enough available IPs available in IpPrefix
validation {
condition = length(var.vips_names) < 10
error_message = "The number of VIPs must be less than 10."
}
}
2 changes: 2 additions & 0 deletions modules/high_availability_new_vnet/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,7 @@ module "example_module" {
use_public_ip_prefix = false
create_public_ip_prefix = false
existing_public_ip_prefix_id = ""
vips_names = []
admin_shell = "/etc/cli.sh"
serial_console_password_hash = "xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx"
maintenance_mode_password_hash = "xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx"
Expand Down Expand Up @@ -122,6 +123,7 @@ module "example_module" {
| **use_public_ip_prefix** | Indicates whether the public IP resources will be deployed with public IP prefix | boolean | true;<br />false;<br />**Default:** false |
| **create_public_ip_prefix** | Indicates whether the public IP prefix will be created or an existing one will be used | boolean | true;<br />false;<br />**Default:** false |
| **existing_public_ip_prefix_id** | The existing public IP prefix resource ID | string | Existing public IP prefix resource ID<br />**Default:** "" |
| **vips_names** | Names for additional Virtual IP addresses beyond the primary cluster VIP. Each name creates a corresponding public IP resource. | list(string) | **Default:** [] |
| **admin_shell** | Enables selecting different admin shells | string | /etc/cli.sh;<br />/bin/bash;<br />/bin/csh;<br />/bin/tcsh;<br />**Default:** "/etc/cli.sh" |
| **serial_console_password_hash** | Optional parameter to enable serial console connection in case of SSH key as authentication type | string | |
| **maintenance_mode_password_hash**| Maintenance mode password hash, relevant only for R81.20 and higher versions | string | |
Expand Down
31 changes: 29 additions & 2 deletions modules/high_availability_new_vnet/main.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ resource "azurerm_public_ip_prefix" "public_ip_prefix" {
name = "${module.common.resource_group_name}-ipprefix"
location = module.common.resource_group_location
resource_group_name = module.common.resource_group_name
prefix_length = 30
prefix_length = length(var.vips_names) > 4 ? 28 : length(var.vips_names) > 0 ? 29 : 30
tags = merge(lookup(var.tags, "public-ip-prefix", {}), lookup(var.tags, "all", {}))
}

Expand All @@ -83,10 +83,24 @@ resource "azurerm_public_ip" "cluster-vip" {
tags = merge(lookup(var.tags, "public-ip", {}), lookup(var.tags, "all", {}))
}

resource "azurerm_public_ip" "vips" {
count = length(var.vips_names)
name = var.vips_names[count.index]
location = module.common.resource_group_location
resource_group_name = module.common.resource_group_name
allocation_method = module.vnet.allocation_method
sku = var.sku
domain_name_label = "${lower(var.vips_names[count.index])}-${count.index}-vip-${random_id.random_id.hex}"
public_ip_prefix_id = var.use_public_ip_prefix ? (var.create_public_ip_prefix ? azurerm_public_ip_prefix.public_ip_prefix[0].id : var.existing_public_ip_prefix_id) : null
tags = merge(lookup(var.tags, "public-ip", {}), lookup(var.tags, "all", {}))
}

resource "azurerm_network_interface" "nic_vip" {
depends_on = [
azurerm_public_ip.cluster-vip,
azurerm_public_ip.public-ip]
azurerm_public_ip.public-ip,
azurerm_public_ip.vips,
]
name = "${var.cluster_name}1-eth0"
location = module.common.resource_group_location
resource_group_name = module.common.resource_group_name
Expand All @@ -109,6 +123,19 @@ resource "azurerm_network_interface" "nic_vip" {
private_ip_address = cidrhost(module.vnet.subnet_prefixes[0], 7)
public_ip_address_id = azurerm_public_ip.cluster-vip.id
}

dynamic "ip_configuration" {
for_each = var.vips_names
content {
name = "cluster-vip-${index(var.vips_names, ip_configuration.value) + 1}"
subnet_id = module.vnet.vnet_subnets[0]
primary = false
private_ip_address_allocation = module.vnet.allocation_method
private_ip_address = cidrhost(module.vnet.subnet_prefixes[0], 7 + index(var.vips_names, ip_configuration.value) + 1)
public_ip_address_id = azurerm_public_ip.vips[index(var.vips_names, ip_configuration.value)].id
}
}

lifecycle {
ignore_changes = [
# Ignore changes to ip_configuration when Re-applying, e.g. because a cluster failover and associating the cluster- vip with the other member.
Expand Down
12 changes: 12 additions & 0 deletions modules/high_availability_new_vnet/variables.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -326,4 +326,16 @@ variable "tags" {
description = "Assign tags by resource."
type = map(map(string))
default = {}
}

variable "vips_names" {
description = "Names to be used for the VIPs"
type = list(string)
default = []

# More than 10 VIPs may result in not enough available IPs available in IpPrefix
validation {
condition = length(var.vips_names) < 10
error_message = "The number of VIPs must be less than 10."
}
}